Merge ~cjwatson/launchpad:sphinx-deprecation into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 1f3aa9dceb30b5cc89a6b5e9116f271282c69a6c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:sphinx-deprecation
Merge into: launchpad:master
Diff against target: 24 lines (+3/-3)
1 file modified
lib/lp/scripts/tests/test_sphinxdocs.py (+3/-3)
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+377210@code.launchpad.net

Commit message

Use sphinx.cmd.build.main instead of sphinx.main

Description of the change

This fixes a deprecation warning:

  RemovedInSphinx20Warning: `sphinx.main()` has moved to `sphinx.cmd.build.main()`.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/scripts/tests/test_sphinxdocs.py b/lib/lp/scripts/tests/test_sphinxdocs.py
2index 194da50..30fb601 100644
3--- a/lib/lp/scripts/tests/test_sphinxdocs.py
4+++ b/lib/lp/scripts/tests/test_sphinxdocs.py
5@@ -7,7 +7,7 @@ __metaclass__ = type
6
7 import os
8
9-import sphinx
10+from sphinx.cmd.build import main as sphinx_main
11 from testtools.content import text_content
12
13 from lp.services.config import config
14@@ -28,8 +28,8 @@ class TestSphinxDocumentation(TestCase):
15 output_dir = self.makeTemporaryDirectory()
16 doc_dir = os.path.join(config.root, 'doc')
17 returncode, stdout, stderr = run_capturing_output(
18- sphinx.main,
19- ['sphinx-build', '-d', '%s/doctrees' % output_dir,
20+ sphinx_main,
21+ ['-d', '%s/doctrees' % output_dir,
22 '-aNqW', doc_dir, '%s/html' % output_dir])
23 self.addDetail('stdout', text_content(stdout))
24 self.addDetail('stderr', text_content(stderr))

Subscribers

People subscribed via source and target branches

to status/vote changes: