Merge ~cjwatson/launchpad:fix-bugtracker-html into launchpad:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 8eca89a525354ed4aee5d8dbcc3c71f089aea09e
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-bugtracker-html
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/lp/app/widgets/product.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Ioana Lasc (community) Approve
Review via email: mp+375400@code.launchpad.net

Commit message

Fix unbalanced tags in ProductBugTrackerWidget

If the project is part of a project group that has a bug tracker, then
there was a superfluous "</label>". Amazingly, this has been wrong
since 2006 and nobody ever seems to have noticed; but it confuses
zope.testbrowser 5.x.

Since the new zope.testbrowser will catch this once we upgrade to it, I
didn't think it was worth adding a separate test.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) :
review: Approve
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

(Oops, didn't mean to self-vote too. But no harm done.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/widgets/product.py b/lib/lp/app/widgets/product.py
2index 346f805..b4b2f40 100644
3--- a/lib/lp/app/widgets/product.py
4+++ b/lib/lp/app/widgets/product.py
5@@ -179,7 +179,7 @@ class ProductBugTrackerWidget(LaunchpadRadioWidget):
6 projectgroup_bugtracker_caption = "Somewhere else"
7 else:
8 projectgroup_bugtracker_caption = structured(
9- 'In the %s bug tracker (<a href="%s">%s</a>)</label>',
10+ 'In the %s bug tracker (<a href="%s">%s</a>)',
11 projectgroup.displayname,
12 canonical_url(projectgroup.bugtracker),
13 projectgroup.bugtracker.title).escapedtext

Subscribers

People subscribed via source and target branches

to status/vote changes: