Launchpad itself

Merge ~cjwatson/launchpad:fix-job-retry-no-oops into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. fix-job-retry-no-oops
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: cdacd5fb373cf26de52a4b6fd7da98f2486e214f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-job-retry-no-oops
Merge into: launchpad:master
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/services/webhooks/tests/test_job.py (+1/-1)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+375325@code.launchpad.net

Commit message

Fix webhook TestViaCronscript

This expected the "Scheduling retry" message to be emitted at WARNING,
but it's now at INFO.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving trivial test fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/webhooks/tests/test_job.py b/lib/lp/services/webhooks/tests/test_job.py
2index a89f539..260698c 100644
3--- a/lib/lp/services/webhooks/tests/test_job.py
4+++ b/lib/lp/services/webhooks/tests/test_job.py
5@@ -702,7 +702,7 @@ class TestViaCronscript(TestCaseWithFactory):
6 expect_returncode=0)
7 self.assertEqual('', stdout)
8 self.assertIn(
9- 'WARNING Scheduling retry due to WebhookDeliveryRetry', stderr)
10+ 'INFO Scheduling retry due to WebhookDeliveryRetry', stderr)
11 self.assertIn(
12 'INFO 1 WebhookDeliveryJob jobs did not complete.\n', stderr)
13

Subscribers

People subscribed via source and target branches

to status/vote changes: