Launchpad itself

Merge ~cjwatson/launchpad:fix-remove-test-event-listener into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. fix-remove-test-event-listener
  4. Merge into master
Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: 1465225a76884331ed13a0738711ccc770b49ae5
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad:fix-remove-test-event-listener
Merge into: launchpad:master
Diff against target: 13 lines (+0/-2)
1 file modified
lib/lp/registry/doc/person-karma.txt (+0/-2)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+374680@code.launchpad.net

Commit message

Fix person-karma.txt

Remove not-very-useful test for karma_helper.listener.event_type, which
no longer works now that KarmaRecorder uses ZopeEventHandlerFixture
rather than TestEventListener.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Self-approving trivial test fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/registry/doc/person-karma.txt b/lib/lp/registry/doc/person-karma.txt
2index ac8f236..7610a70 100644
3--- a/lib/lp/registry/doc/person-karma.txt
4+++ b/lib/lp/registry/doc/person-karma.txt
5@@ -37,8 +37,6 @@ assigned to a given person.
6 >>> from lp.testing.karma import KarmaAssignedEventListener
7 >>> karma_helper = KarmaAssignedEventListener()
8 >>> karma_helper.register_listener()
9- >>> karma_helper.listener.event_type
10- <InterfaceClass ...IKarmaAssignedEvent>
11
12 >>> dummy = salgado.assignKarma('specreviewed', product=firefox)
13 Karma added: action=specreviewed, product=firefox

Subscribers

People subscribed via source and target branches

to status/vote changes: