Merge ~cjwatson/launchpad-layers:interface-apache-vhost-config into launchpad-layers:main
Proposed by
Colin Watson
Status: | Merged |
---|---|
Merged at revision: | 8b7d25a29b8297d491abe6a0c6b69f34e39dddba |
Proposed branch: | ~cjwatson/launchpad-layers:interface-apache-vhost-config |
Merge into: | launchpad-layers:main |
Diff against target: |
68 lines (+56/-0) 2 files modified
apache-vhost-config/interface.yaml (+3/-0) apache-vhost-config/provides.py (+53/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ines Almeida | Approve | ||
Review via email: mp+447537@code.launchpad.net |
Commit message
Add interface to publish Apache virtual host configuration
Description of the change
This implements the interface described under "Using the vhost-config relation" in https:/
To post a comment you must log in.
I'm fairly new to these interfaces, so can you explain me why this interface doesn't need a `requires.py` side? Does the apache charm just access the published data directly?
Regardless, this looks good to me. I like the `dataclass` use, will keep that in mind if I need to build new interfaces that pass data on