Merge lp:~cjwatson/launchpad-buildd/lxd-no-gzip into lp:launchpad-buildd

Proposed by Colin Watson
Status: Merged
Merged at revision: 273
Proposed branch: lp:~cjwatson/launchpad-buildd/lxd-no-gzip
Merge into: lp:launchpad-buildd
Diff against target: 12 lines (+1/-1)
1 file modified
lpbuildd/target/lxd.py (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad-buildd/lxd-no-gzip
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+329913@code.launchpad.net

Commit message

Don't gzip LXD tarballs. Python's gzip is apparently very slow.

Description of the change

This takes unpack-chroot from about 1m59s to about 42s on my laptop.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lpbuildd/target/lxd.py'
2--- lpbuildd/target/lxd.py 2017-08-29 12:51:42 +0000
3+++ lpbuildd/target/lxd.py 2017-08-30 13:01:02 +0000
4@@ -158,7 +158,7 @@
5 with io.BytesIO() as target_file:
6 with tarfile.open(name=tarball_path, mode="r") as source_tarball:
7 with tarfile.open(
8- fileobj=target_file, mode="w:gz") as target_tarball:
9+ fileobj=target_file, mode="w") as target_tarball:
10 self._convert(source_tarball, target_tarball)
11
12 image = self.client.images.create(

Subscribers

People subscribed via source and target branches

to all changes: