Merge ~cjwatson/launchpad-buildd:ci-chown-build-tree into launchpad-buildd:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | f3a4b80e219400ef22f7013f7917188092e8ef21 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad-buildd:ci-chown-build-tree |
Merge into: | launchpad-buildd:master |
Diff against target: |
64 lines (+13/-0) 3 files modified
debian/changelog (+8/-0) lpbuildd/target/run_ci.py (+1/-0) lpbuildd/target/tests/test_run_ci.py (+4/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+436371@code.launchpad.net |
Commit message
In CI jobs, chown the VCS tree to buildd:buildd after fetching it
Description of the change
Otherwise lpcraft running as the buildd user can't read its .git directory. For example, this broke Launchpad's own CI jobs.
To post a comment you must log in.
I've going to self-approve this - it's a regression in launchpad-buildd 227 that affected Launchpad's own CI jobs, and I have a simple end-to-end test case for it on dogfood that I'll be able to run easily (https:/ /code.dogfood. paddev. net/~cjwatson/ +git/git- test).