Merge ~cjwatson/launchpad-buildd:systemd-service into launchpad-buildd:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 1f96833fb1608fd2d497d5c3447077c836a8f7c1 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad-buildd:systemd-service |
Merge into: | launchpad-buildd:master |
Diff against target: |
311 lines (+74/-152) 10 files modified
debian/changelog (+1/-0) debian/control (+1/-1) debian/launchpad-buildd-generator (+19/-0) debian/launchpad-buildd.install (+1/-0) debian/launchpad-buildd.maintscript (+1/-0) debian/launchpad-buildd.service (+15/-0) debian/launchpad-buildd@.service (+26/-0) debian/postrm (+4/-0) debian/rules (+6/-1) dev/null (+0/-150) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+416757@code.launchpad.net |
Commit message
Convert daemon startup to systemd
Description of the change
As well as simplifying away 150 lines of shell script, this avoids relying on su(1) to run the daemon as the `buildd` user, which in turn avoids accidental pollution of the daemon's environment by whatever su(1) thinks is appropriate in interactive environments.
There's a bit of extra complexity due to supporting multiple daemon instances, which is mostly historical at this point, but it was easy enough to handle using a template unit and a generator.
I dropped the explicit hostname condition, since all our builders already have `RUN_NETWORK_
To post a comment you must log in.
Merging failed /jenkins. ols.canonical. com/online- services/ job/launchpad- buildd/ 133/
https:/