Merge ~cjwatson/launchpad-buildd:charmcraft-and-focal into launchpad-buildd:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 8c1273731de865f71aa84f8e9c693c5cf7db0993 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad-buildd:charmcraft-and-focal |
Merge into: | launchpad-buildd:master |
Prerequisite: | ~cjwatson/launchpad-buildd:drop-charm-resources |
Diff against target: |
104 lines (+24/-35) 4 files modified
.gitignore (+1/-2) charm/Makefile (+9/-32) charm/charmcraft.yaml (+13/-0) charm/metadata.yaml (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+416673@code.launchpad.net |
Commit message
charm: Revamp build process and upgrade to focal
Description of the change
`charmcraft` works for reactive charms now, and seems to be simpler to set up once you have the necessary `charmcraft.yaml` incantations.
I dropped support for manually pushing to the charm store, since once this lands we should be able to set up a Launchpad recipe to push it to Charmhub for us.
To post a comment you must log in.
LGTM