Merge ~cjwatson/launchpad-buildd:unpin-python-debian into launchpad-buildd:master

Proposed by Colin Watson
Status: Merged
Approved by: Colin Watson
Approved revision: b92c40244b670fba60363c31e9318852ce4054f1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~cjwatson/launchpad-buildd:unpin-python-debian
Merge into: launchpad-buildd:master
Diff against target: 28 lines (+5/-1)
2 files modified
debian/changelog (+4/-0)
setup.py (+1/-1)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+415819@code.launchpad.net

Commit message

Unversion python-debian requirement

Description of the change

The minimum version required was very old (pre-xenial), so the version constraint was no longer really necessary. Furthermore, the version of the packaged python-debian in >= focal confuses modern pip/setuptools (see https://bugs.launchpad.net/bugs/1926870); removing the version constraint avoids needing to care about this.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 355fb51..5ff6c3c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -2,6 +2,10 @@ launchpad-buildd (209) UNRELEASED; urgency=medium
6
7 * Upgrade charm to bionic and Python 3.
8 * Remove Python 2 support.
9+ * Unversion python-debian requirement, since the minimum version required
10+ was very old (pre-xenial) and the version of the packaged python-debian
11+ confuses modern pip/setuptools (see
12+ https://bugs.launchpad.net/bugs/1926870).
13
14 -- Colin Watson <cjwatson@ubuntu.com> Thu, 10 Feb 2022 09:27:28 +0000
15
16diff --git a/setup.py b/setup.py
17index 559d9a4..680e2c5 100755
18--- a/setup.py
19+++ b/setup.py
20@@ -70,7 +70,7 @@ setup(
21 # that's normally shipped as a system package and specifying it here
22 # causes problems for Launchpad's build system.
23 # 'python-apt',
24- 'python-debian>=0.1.23',
25+ 'python-debian',
26 'requests',
27 'six',
28 'Twisted',

Subscribers

People subscribed via source and target branches