Merge ~cjwatson/launchpad-buildd:backend-capabilities into launchpad-buildd:master
Proposed by
Colin Watson
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | 73e9bd457e2335510a4669d56cc39410f34628a3 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~cjwatson/launchpad-buildd:backend-capabilities |
Merge into: | launchpad-buildd:master |
Prerequisite: | ~cjwatson/launchpad-buildd:lpcraft |
Diff against target: |
155 lines (+19/-9) 8 files modified
lpbuildd/target/backend.py (+2/-0) lpbuildd/target/build_charm.py (+2/-2) lpbuildd/target/build_livefs.py (+2/-2) lpbuildd/target/build_oci.py (+1/-1) lpbuildd/target/build_snap.py (+2/-2) lpbuildd/target/lxd.py (+2/-0) lpbuildd/target/run_ci.py (+2/-2) lpbuildd/tests/fakebuilder.py (+6/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+413899@code.launchpad.net |
Commit message
Express backend capabilities as attributes of Backend
Description of the change
At present there's only one of these capabilities, namely `supports_snapd`. This is cleaner than having target commands test the backend name.
To post a comment you must log in.
LGTM (I did not run the tests, as I still face the lxd-agent issue, which at some point I have to spend some time on)