Merge lp:~cjwatson/indicator-network/porting into lp:indicator-network/14.10

Proposed by Colin Watson
Status: Merged
Approved by: Ted Gould
Approved revision: 322
Merged at revision: 324
Proposed branch: lp:~cjwatson/indicator-network/porting
Merge into: lp:indicator-network/14.10
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~cjwatson/indicator-network/porting
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210394@code.launchpad.net

Commit message

Only build-depend on valgrind on architectures that have it.

Description of the change

With Qt 5.2 plus https://code.launchpad.net/~cjwatson/upstart-app-launch/porting/+merge/210385, indicator-network could build on all architectures, except that it build-depends on valgrind which isn't available everywhere. Since it doesn't actually use valgrind in the default build anyway, it would be fine to restrict the build-dependency to architectures where it's available.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-11-07 11:52:44 +0000
3+++ debian/control 2014-03-11 12:59:12 +0000
4@@ -20,7 +20,7 @@
5 python3-dbusmock,
6 qtbase5-dev,
7 valac (>= 0.22),
8- valgrind,
9+ valgrind [amd64 armhf i386 powerpc],
10 Standards-Version: 3.9.3
11 # If you aren't a member of ~indicator-applet-developers but need to upload
12 # packaging changes, just go ahead. ~indicator-applet-developers will notice

Subscribers

People subscribed via source and target branches