Merge lp:~cjwatson/extract-changelogs/order-by-date into lp:extract-changelogs
Status: | Merged |
---|---|
Merged at revision: | 49 |
Proposed branch: | lp:~cjwatson/extract-changelogs/order-by-date |
Merge into: | lp:extract-changelogs |
Diff against target: |
34 lines (+11/-2) 2 files modified
get-published-since.py (+2/-1) lp-extract-changelogs.py (+9/-1) |
To merge this branch: | bzr merge lp:~cjwatson/extract-changelogs/order-by-date |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Greg Mason (community) | Approve | ||
Ubuntu Core Development Team | Pending | ||
Review via email: mp+291837@code.launchpad.net |
Commit message
Use archive.
Description of the change
Use archive.
The query that extract-changelogs is currently relying on is very slow, and there are some subtle ways in which iterating over the collection can go wrong. For ddeb-retriever, we did a fair bit of work on this:
https:/
https:/
https:/
In the case of extract-changelogs, it should be sufficient to add order_by_date=True, which has the effect of joining fewer tables and using a reasonably well-indexed query to return a collection which is in decreasing ID order. If the collection changes during iteration (as long as you don't try to do any status filtering or similar, as explained in a comment here) then the worst case is that you get the same source package more than once, but extract-changelogs already handles this in LaunchpadChange
Please do test this! I have not done so. However, I hear that extract-changelogs times out when asked to work from a very old starting date, and this should make it behave a lot better.