Merge lp:~cjwatson/dee-qt/powerpc-pie into lp:dee-qt

Proposed by Colin Watson on 2014-03-17
Status: Merged
Approved by: Albert Astals Cid on 2014-03-17
Approved revision: 88
Merged at revision: 88
Proposed branch: lp:~cjwatson/dee-qt/powerpc-pie
Merge into: lp:dee-qt
Diff against target: 17 lines (+7/-0) 1 file modified
To merge this branch: bzr merge lp:~cjwatson/dee-qt/powerpc-pie
Reviewer Review Type Date Requested Status
Albert Astals Cid 2014-03-17 Approve on 2014-03-17
PS Jenkins bot continuous-integration Approve on 2014-03-17
Review via email: mp+211308@code.launchpad.net

Commit Message

Work around pointer equality problem with -Bsymbolic-functions on powerpc/ppc64el.

Description of the Change

dee-qt fails to build on powerpc/ppc64el with a signaltest failure. Albert Astals Cid tracked down http://lists.linaro.org/pipermail/linaro-toolchain/2014-January/003942.html which discusses a similar problem, and there's a hint in that thread that building with PIE support works around the problem. I've confirmed that this patch fixes the build on powerpc and ppc64el; for the sake of conservatism I've written it such that it only affects powerpc-based architectures.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Albert Astals Cid (aacid) wrote :

I can confirm that this makes it build on the porter ppc machines, weather or not this is the appropiate/better bug i have no really opinion on since this is well below my knowledge level

review: Approve
Albert Astals Cid (aacid) wrote :

below in the stack i mean :D

Preview Diff

1=== modified file 'debian/rules'
2--- debian/rules 2013-01-31 18:29:57 +0000
3+++ debian/rules 2014-03-17 13:14:17 +0000
4@@ -4,6 +4,13 @@
5 # Uncomment this to turn on verbose mode.
6 #export DH_VERBOSE=1
7
8+DEB_HOST_GNU_TYPE := $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
9+ifneq (,$(findstring powerpc,$(DEB_HOST_GNU_TYPE)))
10+# Work around pointer equality problem with -Bsymbolic-functions:
11+# http://lists.linaro.org/pipermail/linaro-toolchain/2014-January/003944.html
12+export DEB_BUILD_MAINT_OPTIONS := hardening=+pie
13+endif
14+
15 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
16
17 %:

Subscribers

People subscribed via source and target branches

to all changes: