Merge lp:~cjwatson/alsa-utils/mountall-deadlock into lp:~ubuntu-audio-dev/alsa-utils/ubuntu.natty

Proposed by Colin Watson
Status: Merged
Merged at revision: 82
Proposed branch: lp:~cjwatson/alsa-utils/mountall-deadlock
Merge into: lp:~ubuntu-audio-dev/alsa-utils/ubuntu.natty
Diff against target: 30 lines (+11/-1)
2 files modified
debian/alsa-restore.upstart (+1/-1)
debian/changelog (+10/-0)
To merge this branch: bzr merge lp:~cjwatson/alsa-utils/mountall-deadlock
Reviewer Review Type Date Requested Status
Ubuntu Audio Development Team Pending
Review via email: mp+51841@code.launchpad.net

Description of the change

I've uploaded this to natty, because the previous code deadlocks the boot process on systems with separate /usr and /var. The changelog should explain all:

  * Remove '(mounted MOUNTPOINT=/usr) and (mounted MOUNTPOINT=/var)' from
    /etc/init/alsa-restore.conf's 'start on' condition. Not only is this
    redundant, because runlevel [2345] already implies that /usr and /var
    have been mounted, but it deadlocks mountall in the event of /usr and
    /var both being separate filesystems (LP: #723482).

Please merge.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/alsa-restore.upstart'
--- debian/alsa-restore.upstart 2011-02-21 07:04:05 +0000
+++ debian/alsa-restore.upstart 2011-03-02 00:51:17 +0000
@@ -5,7 +5,7 @@
55
6description "restore sound card(s') mixer state(s)"6description "restore sound card(s') mixer state(s)"
77
8start on runlevel [2345] and (mounted MOUNTPOINT=/usr) and (mounted MOUNTPOINT=/var)8start on runlevel [2345]
99
10task10task
1111
1212
=== modified file 'debian/changelog'
--- debian/changelog 2011-02-22 04:56:58 +0000
+++ debian/changelog 2011-03-02 00:51:17 +0000
@@ -1,3 +1,13 @@
1alsa-utils (1.0.24.2-0ubuntu2) natty; urgency=low
2
3 * Remove '(mounted MOUNTPOINT=/usr) and (mounted MOUNTPOINT=/var)' from
4 /etc/init/alsa-restore.conf's 'start on' condition. Not only is this
5 redundant, because runlevel [2345] already implies that /usr and /var
6 have been mounted, but it deadlocks mountall in the event of /usr and
7 /var both being separate filesystems (LP: #723482).
8
9 -- Colin Watson <cjwatson@ubuntu.com> Wed, 02 Mar 2011 00:43:01 +0000
10
1alsa-utils (1.0.24.2-0ubuntu1) natty; urgency=low11alsa-utils (1.0.24.2-0ubuntu1) natty; urgency=low
212
3 [ David Henningsson ]13 [ David Henningsson ]

Subscribers

People subscribed via source and target branches