Merge lp:~cjohnston/uci-engine/add-graphite-txstatsd into lp:uci-engine

Proposed by Chris Johnston
Status: Rejected
Rejected by: Evan
Proposed branch: lp:~cjohnston/uci-engine/add-graphite-txstatsd
Merge into: lp:uci-engine
Diff against target: 61 lines (+52/-0)
2 files modified
juju-deployer/configs/graphite_http_vhost (+23/-0)
juju-deployer/graphite.yaml.tmpl (+29/-0)
To merge this branch: bzr merge lp:~cjohnston/uci-engine/add-graphite-txstatsd
Reviewer Review Type Date Requested Status
Evan (community) Needs Fixing
Chris Johnston (community) Needs Resubmitting
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+217495@code.launchpad.net

Commit message

Add graphite and txstatsd deployments to the CI engine

Description of the change

Add the ability to deploy Graphite and txstatsd charms to the UCI Engine. The charm locations are temporary while they are improved upon and eventually added to the charm store.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:425
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/553/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/553/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

you've got to pin your branch revno's for this to pass our tarmac logic.

I'd rather see this deploy to a single host rather than needing 2 systems, but you say that's in-progress, so I'm +1

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:425
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/555/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/555/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Evan (ev) wrote :

> you've got to pin your branch revno's for this to pass our tarmac logic.

It works \o/

> The charm locations are temporary while they are improved upon and eventually
> added to the charm store.

Can you please put them in a team-owned branch until they've made their way into the charm store?

Say: lp:~ubuntu-ci-engineering/charms/precise/txstatsd/trunk

Thanks!

review: Needs Fixing
426. By Chris Johnston

Update graphite deployer

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:426
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/595/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/595/rebuild

review: Approve (continuous-integration)
427. By Chris Johnston

Update graphite charm, add postgres and apache support

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:427
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/634/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/634/rebuild

review: Approve (continuous-integration)
428. By Chris Johnston

Switch to team owned graphite charm

Revision history for this message
Chris Johnston (cjohnston) wrote :

Set up to deploy from team branch.

review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:428
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/704/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/704/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) :
review: Needs Fixing
429. By Chris Johnston

Set ansible_ppa false, update names to follow IS req

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:429
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/705/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/705/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Evan (ev) wrote :

You still need to copy or upload the precise ansible package into ppa:canonical-ci-engineering/ci-airline-phase-0

review: Needs Fixing
Revision history for this message
Evan (ev) wrote :

Also, please modify charm-helpers¹ to allow specifying the ppa location for ansible. Webops will have this installed already via basenode from the -cat archive, but we'll want a means to pin the version of ansible that we use. This is currently not possible with it blindly installed from ppa:rquillo/ansible.

Thanks

¹ http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/ansible/__init__.py#L91

review: Needs Fixing

Unmerged revisions

429. By Chris Johnston

Set ansible_ppa false, update names to follow IS req

428. By Chris Johnston

Switch to team owned graphite charm

427. By Chris Johnston

Update graphite charm, add postgres and apache support

426. By Chris Johnston

Update graphite deployer

425. By Chris Johnston

Add graphite and txstatsd deployment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'juju-deployer/configs/graphite_http_vhost'
2--- juju-deployer/configs/graphite_http_vhost 1970-01-01 00:00:00 +0000
3+++ juju-deployer/configs/graphite_http_vhost 2014-05-27 06:55:30 +0000
4@@ -0,0 +1,23 @@
5+<VirtualHost *:80>
6+ ServerAdmin ci-engineering-private@lists.launchpad.net
7+ ErrorLog ${APACHE_LOG_DIR}/graphite-error.log
8+ LogLevel warn
9+ CustomLog ${APACHE_LOG_DIR}/graphite-access.log combined
10+
11+ DocumentRoot /srv/ci-airlines-graphite.canonical.com
12+
13+ <Directory />
14+ Options FollowSymLinks
15+ AllowOverride None
16+ </Directory>
17+
18+ <Directory /srv/ci-airlines-graphite.canonical.com>
19+ Options Indexes FollowSymLinks MultiViews
20+ AllowOverride None
21+ Order allow,deny
22+ Allow from all
23+ </Directory>
24+
25+ RewriteEngine on
26+ RewriteRule ^(.*)$ http://{{ graphite }}$1 [P]
27+</VirtualHost>
28
29=== added file 'juju-deployer/graphite.yaml.tmpl'
30--- juju-deployer/graphite.yaml.tmpl 1970-01-01 00:00:00 +0000
31+++ juju-deployer/graphite.yaml.tmpl 2014-05-27 06:55:30 +0000
32@@ -0,0 +1,29 @@
33+ci-airline-staging:
34+ series: precise
35+ services:
36+ ci-airline-graphite-apache:
37+ charm: apache2
38+ branch: lp:charms/precise/apache2@53
39+ options:
40+ enable_modules: "rewrite proxy proxy_http ssl"
41+ vhost_http_template: include-base64://configs/graphite_http_vhost
42+ servername: ci-airlines-graphite.canonical.com
43+ expose: true
44+ ci-airline-graphite:
45+ charm: graphite
46+ branch: lp:~ubuntu-ci-engineering/charms/precise/graphite/trunk@20
47+ build: "make"
48+ expose: True
49+ options:
50+ ansible_ppa: False
51+ base_dir: "uci-engine"
52+ ci-airline-graphite-gunicorn:
53+ branch: lp:charms/precise/gunicorn@28
54+ charm: gunicorn
55+ ci-airlinegraphite-postgres:
56+ branch: lp:charms/precise/postgresql@84
57+ charm: postgresql
58+ relations:
59+ - ["ci-airline-graphite:pgsql", "ci-airline-graphite-postgres:db"]
60+ - ["ci-airline-graphite:wsgi-file", "ci-airline-graphite-gunicorn:wsgi-file"]
61+ - ["ci-airline-graphite:website", "ci-airline-graphite-apache:reverseproxy"]

Subscribers

People subscribed via source and target branches