Merge lp:~cjohnston/ubuntu-test-cases/add-sys-img-suppport into lp:ubuntu-test-cases/smoke-touch-apps

Proposed by Chris Johnston
Status: Merged
Merged at revision: 60
Proposed branch: lp:~cjohnston/ubuntu-test-cases/add-sys-img-suppport
Merge into: lp:ubuntu-test-cases/smoke-touch-apps
Diff against target: 19 lines (+6/-2)
1 file modified
jenkins/provision.sh (+6/-2)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-test-cases/add-sys-img-suppport
Reviewer Review Type Date Requested Status
Paul Larson Approve
Chris Johnston (community) Needs Resubmitting
Andy Doan (community) Approve
Review via email: mp+178876@code.launchpad.net

Commit message

Add the ability to provision using the system images.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

14 -flock /tmp/phablet-flash-lock phablet-flash -D -s $ANDROID_SERIAL --pending
15 +flock /tmp/phablet-flash-lock phablet-flash -D -s $ANDROID_SERIAL ${TOUCH_IMAGE}

wanna go ahead and remove the "flock" call as well since this is now supported in phablet-tools?

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

Agree with Andy, we can remove all the flock stuff and now would be a good time to do it. It looks like someone already updated phablet-tools on phoenix, so we should be all set now. Otherwise, +1 from me

review: Approve
60. By Chris Johnston

Remove flocking

Revision history for this message
Chris Johnston (cjohnston) wrote :

Eagles don't flock, you have to find them one at a time.

review: Needs Resubmitting
Revision history for this message
Paul Larson (pwlars) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jenkins/provision.sh'
2--- jenkins/provision.sh 2013-08-02 20:07:28 +0000
3+++ jenkins/provision.sh 2013-08-07 13:17:25 +0000
4@@ -15,9 +15,13 @@
5 ANDROID_SERIAL="${ANDROID_SERIAL-015d1884b20c1c0f}" #doanac's nexus7 at home
6 NETWORK_FILE="${NETWORK_FILE-/home/ubuntu/magners-wifi}"
7
8+# Image to use for flashing
9+# Syntax: TOUCH_IMAGE=--ubuntu-bootstrap
10+TOUCH_IMAGE="${TOUCH_IMAGE---pending}"
11+
12 rm -rf clientlogs
13 mkdir clientlogs
14
15-flock /tmp/phablet-flash-lock phablet-flash -D -s $ANDROID_SERIAL --pending
16+phablet-flash -D -s $ANDROID_SERIAL ${TOUCH_IMAGE}
17
18-${UTAH_PHABLET_CMD} -s ${ANDROID_SERIAL} --results-dir ${RESDIR} --network-file=${NETWORK_FILE}
19+${UTAH_PHABLET_CMD} -s ${ANDROID_SERIAL} --results-dir ${RESDIR} --network-file=${NETWORK_FILE} ${TOUCH_IMAGE}

Subscribers

People subscribed via source and target branches