Merge lp:~cjohnston/ubuntu-classroom/voice-bot into lp:~ubuntu-classroom/ubuntu-classroom/classbot

Proposed by Chris Johnston
Status: Merged
Merge reported by: Nathan Handler
Merged at revision: not available
Proposed branch: lp:~cjohnston/ubuntu-classroom/voice-bot
Merge into: lp:~ubuntu-classroom/ubuntu-classroom/classbot
Diff against target: 13 lines (+3/-0)
1 file modified
classbot.pl (+3/-0)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-classroom/voice-bot
Reviewer Review Type Date Requested Status
Nathan Handler Approve
Review via email: mp+19811@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

Voices ClassBot when chan goes +m

20. By Chris Johnston

Voices in $qchan also

Revision history for this message
Nathan Handler (nhandler) wrote :

Can you modify it to use &voice to voice the bot? And it should probably voice the bot before setting +m, just to be safe.

review: Needs Fixing
21. By Chris Johnston

Voicing bot

22. By Chris Johnston

Cleaning up

Revision history for this message
Nathan Handler (nhandler) wrote :

You still are using $server->command("^MSG ChanServ VOICE... to try and voice the bot (Lines 18-20 in the diff shown below). These should be changed to use the voice sub. And is there a reason for the whitespace change at the end?

review: Needs Fixing
23. By Chris Johnston

Cleanup

Revision history for this message
Nathan Handler (nhandler) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'classbot.pl'
2--- classbot.pl 2010-02-21 14:04:52 +0000
3+++ classbot.pl 2010-02-21 14:33:17 +0000
4@@ -122,6 +122,9 @@
5 &refresh_settings();
6 &devoice_all($chan);
7 &devoice_all($qchan);
8+ my($mynick)=$server->{'nick'};
9+ &voice($chan, $mynick, 1);
10+ &voice($qchan, $mynick, 1);
11 for my $key (keys %leaders) {
12 &voice($chan, $key, 1);
13 &voice($qchan, $key, 1);

Subscribers

People subscribed via source and target branches

to all changes: