Merge lp:~cjohnston/ubuntu-ci-services-itself/ts-base_image_default into lp:ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 152
Merged at revision: 153
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/ts-base_image_default
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 46 lines (+6/-1)
3 files modified
juju-deployer/ticket-system.yaml (+1/-0)
ticket_system/ticket/models.py (+3/-1)
ticket_system/ticket_system/settings.py (+2/-0)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/ts-base_image_default
Reviewer Review Type Date Requested Status
Chris Johnston (community) Approve
Andy Doan (community) Approve
Review via email: mp+203363@code.launchpad.net

Commit message

Add a BASE_IMAGE_DEFAULT for defining the default base image to be used by the CI Engine.

Description of the change

Add a BASE_IMAGE_DEFAULT for defining the default base image to be used by the CI Engine.

To post a comment you must log in.
152. By Chris Johnston

Add default base image url to juju deployer

Revision history for this message
Andy Doan (doanac) wrote :

lgtm

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

 merge approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'juju-deployer/ticket-system.yaml'
2--- juju-deployer/ticket-system.yaml 2014-01-24 21:31:18 +0000
3+++ juju-deployer/ticket-system.yaml 2014-01-27 16:44:14 +0000
4@@ -21,6 +21,7 @@
5 django_settings: ticket_system.settings
6 django_south: True
7 django_debug: True
8+ django_extra_settings: BASE_IMAGE_DEFAULT="http://cloud-images.ubuntu.com/releases/13.10/release-20131015/ubuntu-13.10-server-cloudimg-amd64-disk1.img"
9 python_path: /srv/ts_django/ci-utils:/srv/ts_django/ticket_system
10 # this gets shared with gunicorn via a relation-set in this charm
11 wsgi_wsgi_file: ticket_system.wsgi:application
12
13=== modified file 'ticket_system/ticket/models.py'
14--- ticket_system/ticket/models.py 2014-01-24 20:49:37 +0000
15+++ ticket_system/ticket/models.py 2014-01-27 16:44:14 +0000
16@@ -14,6 +14,7 @@
17 # along with this program. If not, see <http://www.gnu.org/licenses/>.
18
19 from django.db import models, IntegrityError
20+from django.conf import settings
21 from project.models import SourcePackage
22 from lazr.enum import DBEnumeratedType, DBItem
23
24@@ -110,7 +111,8 @@
25 status = models.IntegerField(
26 choices=_choices(TicketWorkflowStepStatus), max_length=4096,
27 default=000)
28- base_image = models.CharField(max_length=4096)
29+ base_image = models.CharField(max_length=4096,
30+ default=settings.BASE_IMAGE_DEFAULT)
31 created = models.DateTimeField(auto_now_add=True)
32 updated = models.DateTimeField(auto_now=True)
33 # Comma-separated list of binary names to install or not install when
34
35=== modified file 'ticket_system/ticket_system/settings.py'
36--- ticket_system/ticket_system/settings.py 2014-01-06 21:13:35 +0000
37+++ ticket_system/ticket_system/settings.py 2014-01-27 16:44:14 +0000
38@@ -186,6 +186,8 @@
39 }
40 }
41
42+BASE_IMAGE_DEFAULT = ""
43+
44 # Use local settings if available
45 try:
46 from local_settings import *

Subscribers

People subscribed via source and target branches