Merge lp:~cjohnston/ubuntu-ci-services-itself/temp-remove-tmpfs into lp:~canonical-ci-engineering/ubuntu-ci-services-itself/tarmac-config

Proposed by Chris Johnston on 2014-06-05
Status: Merged
Approved by: Chris Johnston on 2014-06-05
Approved revision: 9
Merged at revision: 9
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/temp-remove-tmpfs
Merge into: lp:~canonical-ci-engineering/ubuntu-ci-services-itself/tarmac-config
Diff against target: 14 lines (+3/-1)
1 file modified
tarmac.conf (+3/-1)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/temp-remove-tmpfs
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) 2014-06-05 Approve on 2014-06-05
Review via email: mp+222199@code.launchpad.net

Commit message

Disable tmpfs for uci-engine to test tarmac broken pipe fix

Description of the change

Tarmac was hitting a 'broken pipe' error when attempting to run on lp:uci-engine.. We implemented a workaround to use TMPFS for running the tests in order to speed things up to get them under 5 minutes... Tarmac now has an attempted fix, so we need to test it. Let's disable TMPFS to have a chance to test the fixes. After the fix has been tested, let's re-enable TMPFS because speed == good!

To post a comment you must log in.
Vincent Ladeuil (vila) wrote :

As in: you will deploy https://code.launchpad.net/~dobey/tarmac/close-conn/+merge/221977 and test that even if our tests take longer than 5 minutes tarmac doesn't fail right ?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tarmac.conf'
2--- tarmac.conf 2014-05-29 16:07:48 +0000
3+++ tarmac.conf 2014-06-05 14:10:27 +0000
4@@ -5,7 +5,9 @@
5 tree_dir = /home/ubuntu/projects/uci-engine
6 voting_criteria = Approve >=1
7 commit_message_template = [r=<approved_by>] <commit_message> <bugs_fixed> from <author>
8-verify_command = export CI_DEPS_LOCAL=/home/ubuntu/projects/uci-deps && TMPFS=1 ./tarmac.sh
9+# Removing TMPFS=1 in order to test the fix to tarmac, will revert after fix is approved/denied
10+#verify_command = export CI_DEPS_LOCAL=/home/ubuntu/projects/uci-deps && TMPFS=1 ./tarmac.sh
11+verify_command = export CI_DEPS_LOCAL=/home/ubuntu/projects/uci-deps && ./tarmac.sh
12 rejected_branch_status = Work in progress
13
14 [lp:uci-engine/mt-hood]

Subscribers

People subscribed via source and target branches