Merge lp:~cjohnston/ubuntu-ci-services-itself/js-underscores-1283008 into lp:ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 261
Merged at revision: 265
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/js-underscores-1283008
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 15 lines (+2/-2)
1 file modified
webui/webui.js (+2/-2)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/js-underscores-1283008
Reviewer Review Type Date Requested Status
Evan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+207724@code.launchpad.net

Commit message

Remove "_" from key names in WebUI

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:261
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/209/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/209/rebuild

review: Approve (continuous-integration)
Revision history for this message
Evan (ev) wrote :

While not the most elegant looking thing in the world, this appears to be the common approach in Javascript land. +1.

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :
Download full text (14.5 KiB)

The attempt to merge lp:~cjohnston/ubuntu-ci-services-itself/js-underscores-1283008 into lp:ubuntu-ci-services-itself failed. Below is the output from the failed tests.

New python executable in /tmp/tmp.SLUiPlLeH5/bin/python
Installing distribute.............................................................................................................................................................................................done.
Installing pip...............done.
== Testing ci-utils ....
Downloading/unpacking python-swiftclient==1.8.0
  Running setup.py egg_info for package python-swiftclient

    Installed /tmp/tmp.SLUiPlLeH5/build/python-swiftclient/pbr-0.6-py2.7.egg
    [pbr] Processing SOURCES.txt
    warning: LocalManifestMaker: standard file '-c' not found

    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    warning: no files found matching '*' under directory 'tools'
Downloading/unpacking simplejson>=2.0.9 (from python-swiftclient==1.8.0)
  Running setup.py egg_info for package simplejson

Installing collected packages: python-swiftclient, simplejson
  Running setup.py install for python-swiftclient
    [pbr] Reusing existing SOURCES.txt
    changing mode of build/scripts-2.7/swift from 664 to 775
    changing mode of /tmp/tmp.SLUiPlLeH5/bin/swift to 775
  Running setup.py install for simplejson
    building 'simplejson._speedups' extension
    gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/usr/include/python2.7 -c simplejson/_speedups.c -o build/temp.linux-x86_64-2.7/simplejson/_speedups.o
    gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro build/temp.linux-x86_64-2.7/simplejson/_speedups.o -o build/lib.linux-x86_64-2.7/simplejson/_speedups.so

Successfully installed python-swiftclient simplejson
Cleaning up...
Downloading/unpacking python-glanceclient==0.12.0
  Running setup.py egg_info for package python-glanceclient

    Installed /tmp/tmp.SLUiPlLeH5/build/python-glanceclient/pbr-0.6-py2.7.egg
    [pbr] Excluding argparse: Python 2.6 only dependency
    [pbr] Processing SOURCES.txt
    warning: LocalManifestMaker: standard file '-c' not found

    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
    warning: no previously-included files matching '*.pyc' found anywhere in distribution
    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
Downloading/unpacking pbr>=0.5.21,<1.0 (from python-glanceclient==0.12.0)
  Running setup.py egg_info for package pbr
    [pbr] Processing SOURCES.txt
    warning: LocalManifestMaker: standard file '-c' not found

    warning: no previously-included files found matching '.gitignore'
    warning: no previously-included files found matching '.gitreview'
    warning: no previously-included files matching '*.pyc' found anywhere in...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'webui/webui.js'
2--- webui/webui.js 2014-02-17 10:13:29 +0000
3+++ webui/webui.js 2014-02-21 19:06:44 +0000
4@@ -211,10 +211,10 @@
5 var span = Y.webui.add_artifacts(data['artifact']);
6 value = span.getHTML();
7 }
8-
9+ key = key.replace("_", " ");
10 tr = Y.Node.create('<tr></tr>');
11 table.appendChild(tr);
12- tr.appendChild(Y.Node.create('<th>' + key + ': </th>'));
13+ tr.appendChild(Y.Node.create('<th>' + key.charAt(0).toUpperCase() + key.slice(1) + ': </th>'));
14 tr.appendChild(Y.Node.create('<td>' + value + '</td>'));
15 }
16

Subscribers

People subscribed via source and target branches