Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/get-swift-image

Revision history for this message
Andy Doan (doanac) wrote :

looks good. we should just get this merged i think. one note:

246 + self.image_path = os.path.join(
247 + utils.HOME, 'd62d3d9a-ac3d-11e3-847d-fa163eaf5928.img')
248 + self.addCleanup(self._remove_image)

you could use tempfile for that now so the test doesn't mess with $HOME

« Back to merge proposal