Merge lp:~cjohnston/ubuntu-ci-services-itself/fix-ts-test-typo into lp:ubuntu-ci-services-itself
- fix-ts-test-typo
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Chris Johnston |
Approved revision: | 125 |
Merged at revision: | 125 |
Proposed branch: | lp:~cjohnston/ubuntu-ci-services-itself/fix-ts-test-typo |
Merge into: | lp:ubuntu-ci-services-itself |
Diff against target: |
22 lines (+3/-2) 1 file modified
ticket_system/ticket/tests/test_write_api.py (+3/-2) |
To merge this branch: | bzr merge lp:~cjohnston/ubuntu-ci-services-itself/fix-ts-test-typo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Johnston (community) | Approve | ||
Ursula Junque (community) | Approve | ||
Review via email:
|
Commit message
Fix test copy/paste issue
Description of the change
- 76. By Andy Doan
-
[r=Parameswaran Sivatharman] ensure we use UTC in ppa-assigner
django/postgres has a bit of weirdness in the TIME_ZONE setting UTC interaction. This ensures we are always storing dates as UTC and comparing them using UTC. The testReserveTime
stamp was broke which exposed the issue. This fixes that test case. from Andy Doan - 77. By Andy Doan
-
[r=Parameswaran Sivatharman] ppa-assigner: allow setup.py to run unit tests
django's mechanism for running unit-tests doesn't work out of the
box with setuptools. This is a small hack to allow you to run:./setup.py test from Andy Doan
- 78. By Para Siva
-
[r=Andy Doan] ppa assigner Reserve/ Rlease tests from Parameswaran Sivatharman
- 79. By Andy Doan
-
[r=Chris Johnston] add a lightweight script for MP testing
This script sets up a simple venv and runs the unit tests for each
component. We can use this with our tarmac MP logic to get a bit
more test coverage.
from Andy Doan - 80. By Andy Doan
-
[r=Chris Johnston] update ticket_system to work with the tarmac.sh script from Andy Doan
- 81. By Chris Johnston
-
[r=Ursula Junque] Fixes tests that were failing but not noticed due to a typo. from Chris Johnston
- 82. By Joe Talbott
-
[r=Paul Larson] data-store - Make put_file() return the url to the file. from Joe Talbott
- 83. By Ursula Junque
-
[r=Chris Johnston] Fixing the way ChangesProcessor handles paths, so we don't have to worry about setting the directory where the files to upload are; also added a support for a provided directory, if that's different than where the changes file is. from Ursula Junque
- 84. By Chris Johnston
-
[r=Joe Talbott] Add ticket status APIs from Chris Johnston
- 85. By Ursula Junque
-
[r=Chris Johnston] This will make ChangesProcessor to return the .changes relative name, not the full path as before. from Ursula Junque
- 86. By Ursula Junque
-
[r=Chris Johnston] Renamed validate_files to validate and added a test to ChangesProcesso
r.process( ) from Ursula Junque - 87. By Vincent Ladeuil
-
[r=Andy Doan] A first rough cut at a restish test runner component. from Vincent Ladeuil
- 88. By Andy Doan
-
[r=Andy Doan, Francis Ginther, Vincent Ladeuil] lander: exit with proper error code and include components in logs
the jenkins jobs always keep proceeding because the jobs don't exit
with non-zero rc on failure.also update the logger so multiple components can be named
from Andy Doan - 89. By Para Siva
-
[r=Andy Doan, Vincent Ladeuil] Some basic ticket system juju tests. from Parameswaran Sivatharman
- 90. By Andy Doan
-
[r=Vincent Ladeuil] convert cli component to use setup.py script and let it run unit-tests from Andy Doan
- 91. By Paul Larson
-
[r=Paul Larson, Andy Doan] Add image-builder code to modify cloud images with the specified PPAs and packages from Paul Larson
- 92. By Vincent Ladeuil
-
[r=Chris Johnston, Andy Doan] Introduce a test runner that understand our multi-component layout. from Vincent Ladeuil
- 93. By Andy Doan
-
[r=Andy Doan, Francis Ginther] create a progress-trigger API and wire up bsbuilder with it
This stubs out the basics of a progress-trigger queue interaction
and uses the lander-bsbuilder interaction as the first user of it. We
are able to use the current run-forever logic with some minor tweaking
to make it aware of a consumer that can say to exit.It leaves a TODO for updating the ticket-system. However, the
semantics of this API should be close enough to the states
of the ticket-system to make this work.
from Andy Doan - 94. By Evan
-
[r=Vincent Ladeuil, Martin Packman] Add a script to deploy the entire environment (juju-deployer/
deploy) .
Add a juju-gui service. from Evan Dandrea - 95. By Evan
-
[r=Andy Doan] adds a test runner for the Amulet tests from Evan Dandrea
- 96. By Ursula Junque
-
[r=Chris Johnston, Joe Talbott] Ticket read API returns status/workflow step description; using enums to describe workflow in models.py from Ursula Junque
- 97. By Francis Ginther
-
[r=Francis Ginther, Vincent Ladeuil] Move jenkins job name and token to config parameters and fix the deployer config. from Francis Ginther
- 98. By Joe Talbott
-
[r=Francis Ginther] docs - Add data-store design document. from Joe Talbott
- 99. By Joe Talbott
-
[r=Francis Ginther] docs - Add data-store design document. from Joe Talbott
- 100. By Andy Doan
-
[r=Parameswaran Sivatharman, Evan Dandrea] fix issues in tests/run to get it working out-of-the-box from Andy Doan
- 101. By Andy Doan
-
[r=Francis Ginther] update the ppa-assigner documentation for what happens when an error occurs from Andy Doan
- 102. By Ursula Junque
-
[r=Chris Johnston] Fixing silly dependency misplacement. from Ursula Junque
- 103. By Andy Doan
-
[r=Francis Ginther] allow ppa-assigner to require a naming pattern
this allows you to not use all the ppa's assigned to a given user
from Andy Doan - 104. By Chris Johnston
-
[r=Chris Johnston, Andy Doan, Joe Talbott] Adds the ability to create a ticket and check ticket status to the CLI from Chris Johnston
- 105. By Ursula Junque
-
[r=Chris Johnston] Exposing source package version, parsed from changes file, in ChangesProcessor. from Ursula Junque
- 106. By Ursula Junque
-
[r=Chris Johnston] Add read API to edit subtickets indexed by pk from Ursula Junque
- 107. By Ursula Junque
-
[r=Chris Johnston] Fixes a bug found in ci_libs/ticket.py code that causes uploads to data store to fail. It also adds error handling and error messages in the main script. from Ursula Junque
- 108. By Chris Johnston
-
[r=Ursula Junque] Make some update/fixes to the TS docs from Chris Johnston
- 109. By Vincent Ladeuil
-
[r=Andy Doan] test runner juju-deployer config and its integration test. from Vincent Ladeuil
- 110. By Paul Larson
-
[r=Andy Doan] Handle downloading a cloud image, mounting it, modifying it, and unmounting it from Paul Larson
- 111. By Francis Ginther
-
[r=Andy Doan] Update lander_archiver.py to actually put the artifacts in the data store and switch to the ci-train jenkins charm. from Francis Ginther
- 112. By Chris Johnston
-
[r=Andy Doan, Francis Ginther] Add next/ API for the lander to get tickets from the TS from Chris Johnston
- 113. By Andy Doan
-
[r=Francis Ginther] lander: add wrapper for freeing ppa from Andy Doan
- 114. By Andy Doan
-
[r=Francis Ginther] ppa-assigner: include time deltas for cleaning ppas
just adds the time LP took to clean a PPA to the log file
from Andy Doan - 115. By Francis Ginther
-
[r=Paul Larson, Evan Dandrea] Add use case examples of the APIs in action. from Francis Ginther
- 116. By Evan
-
[r=Vincent Ladeuil] Turns the deploy script from shell code into python. from Evan Dandrea
- 117. By Francis Ginther
-
[r=Andy Doan] Specify the lander jenkins plugins as a configuration option. from Francis Ginther
- 118. By Chris Johnston
-
[r=Chris Johnston, Ursula Junque] Switch the CLI to use the source_package_name property from Chris Johnston
- 119. By Chris Johnston
-
[r=Ursula Junque] Change logging to fix CLI status checks 1270027 from Chris Johnston
- 120. By Chris Johnston
-
[r=Francis Ginther] Updates of the TS docs from Chris Johnston
- 121. By Paul Larson
-
[r=Parameswaran Sivatharman, Andy Doan] Hook up image builder api and do the image build with a rabbit worker from Paul Larson
- 122. By Francis Ginther
-
[r=Andy Doan] Update Branch Source Builder API documentation. from Francis Ginther
- 123. By Francis Ginther
-
[r=Andy Doan] Minor updates to the lander API documentation. from Francis Ginther
- 124. By Chris Johnston
-
[r=Ursula Junque, Francis Ginther, Andy Doan] Automatically get the version number from the source being uploaded. from Chris Johnston
- 125. By Chris Johnston
-
Fix typo in test
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Chris Johnston (cjohnston) : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Chris Johnston (cjohnston) wrote : | # |
merge approved
Preview Diff
1 | === modified file 'ticket_system/ticket/tests/test_write_api.py' |
2 | --- ticket_system/ticket/tests/test_write_api.py 2014-01-15 00:32:04 +0000 |
3 | +++ ticket_system/ticket/tests/test_write_api.py 2014-01-20 19:30:17 +0000 |
4 | @@ -117,7 +117,7 @@ |
5 | source_package_upload=self.spu) |
6 | self.resource = 'subticket/' |
7 | self.detail_url = self.resource + '{0}/'.format(self.subticket.pk) |
8 | - self.ticket_uri = '/api/v1/spu/{0}/'.format(self.ticket.pk) |
9 | + self.ticket_uri = '/api/v1/ticket/{0}/'.format(self.ticket.pk) |
10 | self.spu_uri = '/api/v1/spu/{0}/'.format(self.spu.pk) |
11 | self.post_subticket_data = { |
12 | 'source_package_upload': self.spu_uri, |
13 | @@ -200,7 +200,8 @@ |
14 | def setUp(self): |
15 | super(APIUpdateTicketStatuses, self).setUp('/api/v1') |
16 | self.ticket = mommy.make('Ticket') |
17 | - self.ticket_detail_url = 'updateticketstatus/{0}/'.format(self.ticket.pk) |
18 | + self.ticket_detail_url = 'updateticketstatus/{0}/'.format( |
19 | + self.ticket.pk) |
20 | |
21 | def test_patch_ticket_status(self): |
22 | new_data = { |
Simple fix, approving.