Merge lp:~cjohnston/ubuntu-ci-services-itself/de-ui-ts into lp:ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Rejected
Rejected by: Chris Johnston
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/de-ui-ts
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 30 lines (+3/-6)
1 file modified
juju-deployer/ticket-system.yaml (+3/-6)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/de-ui-ts
Reviewer Review Type Date Requested Status
Andy Doan (community) Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+204307@code.launchpad.net

Commit message

Remove the WebUI from the TS deployment

To post a comment you must log in.
191. By Chris Johnston

Remove WebUI from deploy with the TS

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:192
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/51/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/51/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

Can you explain why you want this?

The way our deployment/charms currently work, this is the only way we can get the webui to deploy with everything and know how to talk to the ticket-system. If you are going to do this, I think you need to include changes that will also know how to deploy the webui and have it understand where the ticket-system is located.

I agree it should eventually be this way (actually, not whole-heartedly), but as our code base exists today this is just removing functionality.

review: Needs Information

Unmerged revisions

191. By Chris Johnston

Remove WebUI from deploy with the TS

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'juju-deployer/configs/webui_http_vhost' => 'juju-deployer/configs/ts_http_vhost'
2=== modified file 'juju-deployer/ticket-system.yaml'
3--- juju-deployer/ticket-system.yaml 2014-01-29 20:13:31 +0000
4+++ juju-deployer/ticket-system.yaml 2014-01-31 18:18:10 +0000
5@@ -1,16 +1,14 @@
6 ci-airline-staging:
7 series: precise
8 services:
9- webui-apache:
10+ ts-apache:
11 charm: apache2
12 branch: lp:charms/precise/apache2
13 options:
14 enable_modules: "rewrite proxy proxy_http ssl"
15- vhost_http_template: include-base64://configs/webui_http_vhost
16+ vhost_http_template: include-base64://configs/ts_http_vhost
17 servername: ci-airlines.canonical.com
18 expose: true
19- webui-app:
20- charm: webui
21 ts-django:
22 charm: python-django
23 options:
24@@ -37,5 +35,4 @@
25 relations:
26 - ["ts-django:pgsql", "ts-postgres:db"]
27 - ["ts-django:wsgi", "ts-gunicorn:wsgi-file"]
28- - ["webui-app:website", "webui-apache:website"]
29- - ["ts-django:website", "webui-apache:reverseproxy"]
30+ - ["ts-django:website", "ts-apache:reverseproxy"]

Subscribers

People subscribed via source and target branches