Merge lp:~cjohnston/ubuntu-ci-services-itself/cli-sp-name-prop into lp:ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 116
Merged at revision: 118
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/cli-sp-name-prop
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 41 lines (+3/-4)
2 files modified
cli/ci_libs/file_handler.py (+1/-3)
cli/ci_libs/ticket.py (+2/-1)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/cli-sp-name-prop
Reviewer Review Type Date Requested Status
Chris Johnston (community) Approve
Ursula Junque (community) Approve
Review via email: mp+202035@code.launchpad.net

Commit message

Switch the CLI to use the source_package_name property

To post a comment you must log in.
Revision history for this message
Ursula Junque (ursinha) wrote :

It was using the ChangesProcessor.sourcepackage attribute before, the difference I see now is where it's set. I'm fine with the change.

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

 merge approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cli/ci_libs/file_handler.py'
2--- cli/ci_libs/file_handler.py 2014-01-15 14:16:20 +0000
3+++ cli/ci_libs/file_handler.py 2014-01-17 03:00:28 +0000
4@@ -62,7 +62,6 @@
5 else:
6 self.files_to_upload_dir = os.path.dirname(changes_filepath)
7 self.files_to_upload = []
8- self.sourcepackage = ''
9 self.changes = None
10
11 @property
12@@ -94,14 +93,13 @@
13 else:
14 raise FileToUploadNotFound(file_)
15 self.files_to_upload.append(self.changes.get_changes_file())
16- self.sourcepackage = self.changes.get_package_name()
17 except Exception, exc:
18 raise exc
19
20 def process(self, check_signature=False):
21 self.parse()
22 self.validate(check_signature=check_signature)
23- return self.files_to_upload, self.sourcepackage
24+ return self.files_to_upload
25
26
27 def upload_files(file_path, ticket_id):
28
29=== modified file 'cli/ci_libs/ticket.py'
30--- cli/ci_libs/ticket.py 2014-01-15 14:16:20 +0000
31+++ cli/ci_libs/ticket.py 2014-01-17 03:00:28 +0000
32@@ -41,7 +41,8 @@
33 changes = ChangesProcessor(
34 changes_filepath=changes_filepath,
35 files_to_upload_dir=args.files_to_upload_dir)
36- self.files, self.sourcepackage = changes.process()
37+ self.files = changes.process()
38+ self.sourcepackage = changes.source_package_name
39
40 def _process(self, args):
41 self._create_spu(args)

Subscribers

People subscribed via source and target branches