Merge lp:~cjohnston/summit/today into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 128
Merged at revision: 129
Proposed branch: lp:~cjohnston/summit/today
Merge into: lp:summit
Diff against target: 43 lines (+9/-6)
2 files modified
summit/schedule/views.py (+8/-5)
summit/urls.py (+1/-1)
To merge this branch: bzr merge lp:~cjohnston/summit/today
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+68200@code.launchpad.net

Commit message

Changes /today url to /summit_name/today

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/views.py'
2--- summit/schedule/views.py 2011-05-15 02:19:17 +0000
3+++ summit/schedule/views.py 2011-07-18 00:53:22 +0000
4@@ -101,6 +101,14 @@
5
6 @summit_required
7 def by_date(request, summit, attendee, date):
8+ return _process_date_view(request, summit, attendee, date)
9+
10+@summit_required
11+def today_view(request, summit, attendee):
12+ today = summit.localize(datetime.datetime.now()).date()
13+ return _process_date_view(request, summit, attendee, today.strftime("%Y-%m-%d"))
14+
15+def _process_date_view(request, summit, attendee, date):
16 schedule = schedule_factory(request, summit, attendee, date=date)
17
18 if request.method == 'POST':
19@@ -127,11 +135,6 @@
20 return render_to_response("schedule/schedule.html", context,
21 context_instance=RequestContext(request))
22
23-def today_view(request):
24- summit = Summit.objects.next()
25- today = summit.localize(datetime.datetime.now()).date()
26- return by_date(request, summit.name, today.strftime("%Y-%m-%d"))
27-
28 @summit_required
29 def next_session(request, summit, attendee):
30 schedule = Schedule(request, summit, attendee)
31
32=== modified file 'summit/urls.py'
33--- summit/urls.py 2011-05-22 18:08:35 +0000
34+++ summit/urls.py 2011-07-18 00:53:22 +0000
35@@ -52,7 +52,7 @@
36 )
37
38 urlpatterns += patterns('summit.schedule.views',
39- (r'^today/$', 'today_view'),
40+ (r'^(?P<summit_name>[\w-]+)/today/$', 'today_view'),
41 url(r'^past/', 'past', name='past'),
42 url(r'^mobile/', 'mobile', name='mobile'),
43 url(r'^logout$', 'logout_view', name='logout'),

Subscribers

People subscribed via source and target branches