Merge lp:~cjohnston/summit/995789 into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 414
Merge reported by: Chris Johnston
Merged at revision: not available
Proposed branch: lp:~cjohnston/summit/995789
Merge into: lp:summit
Diff against target: 16 lines (+0/-7)
1 file modified
summit/schedule/models/summitmodel.py (+0/-7)
To merge this branch: bzr merge lp:~cjohnston/summit/995789
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+109661@code.launchpad.net

Commit message

Removes code in summitmodel from lpupdate which deletes meetings that have a spec_url which isn't a launchpad blueprint

To post a comment you must log in.
Revision history for this message
Joey Stanford (joey) wrote :

Could do with some drive by comments so others know what's happening in this block. We're deleting the deleting but it's not evident if you look at the code.

Revision history for this message
Michael Hall (mhall119) wrote :

Looks fine. I'm not worried about commenting this, as we're going to deprecate the whole thing as soon as we can make a cleaner break from Launchpad

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/summitmodel.py'
2--- summit/schedule/models/summitmodel.py 2012-05-18 18:57:14 +0000
3+++ summit/schedule/models/summitmodel.py 2012-06-11 15:26:24 +0000
4@@ -273,13 +273,6 @@
5 sprint_info = self._get_sprint_info_from_launchpad(url)
6 in_lp |= self.update_from_launchpad_response(sprint_info)
7
8- in_db = set(m for m in self.meeting_set.exclude(spec_url=''))
9-
10- for extra in in_db.difference(in_lp):
11- if not len(extra.agenda_set.all()):
12- print "will delete %s" % extra.name
13- extra.delete()
14-
15 self.last_update = datetime.utcnow()
16 self.save()
17

Subscribers

People subscribed via source and target branches