Merge lp:~cjohnston/qa-dashboard/respect-publish into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 729
Merged at revision: 728
Proposed branch: lp:~cjohnston/qa-dashboard/respect-publish
Merge into: lp:qa-dashboard
Diff against target: 113 lines (+25/-7)
2 files modified
bootspeed/api.py (+16/-4)
bootspeed/views.py (+9/-3)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/respect-publish
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Joe Talbott Approve
Review via email: mp+211592@code.launchpad.net

Commit message

Update bootspeed to only display published data

To post a comment you must log in.
729. By Chris Johnston

Same for views

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:729
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/313/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/313/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bootspeed/api.py'
2--- bootspeed/api.py 2013-05-18 00:08:36 +0000
3+++ bootspeed/api.py 2014-03-18 17:44:04 +0000
4@@ -36,7 +36,11 @@
5 def overall(request, arch):
6 # do some reversed sorting to get the latest images.
7 images = reversed(
8- Image.objects.filter(arch=arch, image_type='daily').order_by(
9+ Image.objects.filter(
10+ arch=arch,
11+ image_type='daily',
12+ publish=True,
13+ ).order_by(
14 '-build_number')[:MAX_RESULTS]
15 )
16
17@@ -85,7 +89,9 @@
18 res = ImageMachineAgg.objects.filter(
19 machine=machine_id,
20 image__arch=arch,
21- image__image_type='daily'
22+ image__image_type='daily',
23+ image__publish=True,
24+ publish=True,
25 ).order_by(
26 'image__build_number'
27 )[:MAX_RESULTS]
28@@ -94,6 +100,8 @@
29 machine=machine_id,
30 image__arch=arch,
31 image__image_type='release',
32+ image__publish=True,
33+ publish=True,
34 ).order_by(
35 '-image__build_number'
36 )
37@@ -134,12 +142,16 @@
38 machine=machine_id,
39 image__arch=arch,
40 image__image_type='daily',
41+ image__publish=True,
42+ publish=True,
43 ).order_by('image__build_number')[:MAX_RESULTS]
44
45 last_releases = ImageMachineAgg.objects.filter(
46 machine=machine_id,
47 image__arch=arch,
48 image__image_type='release',
49+ image__publish=True,
50+ publish=True,
51 ).order_by('-image__build_number')
52
53 if last_releases.count() > 0:
54@@ -227,13 +239,13 @@
55 return JSONResponse(json.dumps(error_data))
56
57 machine = machines[0]
58- image = Image.objects.filter(md5=md5)
59+ image = Image.objects.filter(md5=md5, publish=True)
60
61 if image.count() != 1:
62 error_data['message'] = "unknown md5: {}".format(md5)
63 return JSONResponse(json.dumps(error_data))
64
65- image_results = image.imageresult_set.filter(machine=machine)
66+ image_results = image.imageresult_set.filter(machine=machine, publish=True)
67
68 data = json.dumps({
69 "image_id": image.id,
70
71=== modified file 'bootspeed/views.py'
72--- bootspeed/views.py 2014-01-07 01:42:37 +0000
73+++ bootspeed/views.py 2014-03-18 17:44:04 +0000
74@@ -69,7 +69,7 @@
75
76 @require_GET
77 def overview(request, release=None):
78- images = Image.objects.all()
79+ images = Image.objects.filter(publish=True)
80 releases = _get_bootspeed_releases()
81
82 if release is not None:
83@@ -94,7 +94,11 @@
84 if arch is None:
85 return redirect('arch/amd64/')
86
87- result = ImageResult.objects.filter(image__arch=arch).distinct(
88+ result = ImageResult.objects.filter(
89+ image__arch=arch,
90+ image__publish=True,
91+ publish=True,
92+ ).distinct(
93 'machine__name'
94 )
95 arches = _get_bootspeed_arches()
96@@ -154,6 +158,8 @@
97 qs = ImageResult.objects.filter(
98 machine__id=machine_id,
99 image__arch=arch,
100+ image__publish=True,
101+ publish=True,
102 ).prefetch_related(
103 'image',
104 'machine',
105@@ -204,7 +210,7 @@
106 def image_bugs_overview(request):
107 images = JobImage.objects.annotate(
108 imagebuild_count=models.Count(
109- 'imagebuild'
110+ 'imagebuild',
111 )
112 ).filter(imagebuild_count__gt=0).order_by(
113 '-build_number',

Subscribers

People subscribed via source and target branches