Merge lp:~cjohnston/qa-dashboard/rel-path into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 689
Merged at revision: 690
Proposed branch: lp:~cjohnston/qa-dashboard/rel-path
Merge into: lp:qa-dashboard
Diff against target: 168 lines (+21/-34)
3 files modified
common/static/css/jquery.dataTables.css (+11/-23)
common/static/css/new-style.css (+2/-3)
common/static/css/style.css (+8/-8)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/rel-path
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+197369@code.launchpad.net

Commit message

Switch assets to using rel-path

Description of the change

Dashboard plan for charming:

- Add all assets back to lp:qa-dashboard
- Create 'assets' branch for the web team to use to include in assets.u.c (lp:qa-dashboard/assets)
- Create a script to automatically copy staticfiles from lp:qa-dashboard to lp:qa-dashboard/assets when there is an update to assets
- Switch the dashboard to use assets.ubuntu.com for static assets
  * this is the reason for the change in paths in this MP. making the paths relative will cause the site to use the proper assets

Since the assets will be versioned, I will be adding the ability to the script above to update what revision the site needs to look for in assets.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:689
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

can you elaborate a little? ie - I think you are doing this because you just moved the assets back into our code-base in plans for a new way to use assets.ubuntu.com. However, maybe sharing the whole plan up-front will allow us to understand if each MP makes sense.

Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/static/css/jquery.dataTables.css'
2--- common/static/css/jquery.dataTables.css 2013-04-29 17:43:14 +0000
3+++ common/static/css/jquery.dataTables.css 2013-12-02 13:46:27 +0000
4@@ -1,4 +1,3 @@
5-
6 /*
7 * Table
8 */
9@@ -33,17 +32,6 @@
10 text-align: center;
11 }
12
13-/*
14-table.dataTable tr.odd { background-color: #E2E4FF; }
15-table.dataTable tr.even { background-color: white; }
16-
17-table.dataTable tr.odd td.sorting_1 { background-color: #D3D6FF; }
18-table.dataTable tr.odd td.sorting_2 { background-color: #DADCFF; }
19-table.dataTable tr.odd td.sorting_3 { background-color: #E0E2FF; }
20-table.dataTable tr.even td.sorting_1 { background-color: #EAEBFF; }
21-table.dataTable tr.even td.sorting_2 { background-color: #F2F3FF; }
22-table.dataTable tr.even td.sorting_3 { background-color: #F9F9FF; }
23-*/
24
25 /*
26 * Table wrapper
27@@ -127,13 +115,13 @@
28 margin-left: 10px;
29 }
30
31-.paginate_enabled_previous { background: url('//assets.ubuntu.com/sites/dashboard/img/back_enabled.png') no-repeat top left; }
32-.paginate_enabled_previous:hover { background: url('//assets.ubuntu.com/sites/dashboard/img/back_enabled_hover.png') no-repeat top left; }
33-.paginate_disabled_previous { background: url('//assets.ubuntu.com/sites/dashboard/img/back_disabled.png') no-repeat top left; }
34+.paginate_enabled_previous { background: url('../images/back_enabled.png') no-repeat top left; }
35+.paginate_enabled_previous:hover { background: url('../images/back_enabled_hover.png') no-repeat top left; }
36+.paginate_disabled_previous { background: url('../images/back_disabled.png') no-repeat top left; }
37
38-.paginate_enabled_next { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_enabled.png') no-repeat top right; }
39-.paginate_enabled_next:hover { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_enabled_hover.png') no-repeat top right; }
40-.paginate_disabled_next { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_disabled.png') no-repeat top right; }
41+.paginate_enabled_next { background: url('../images/forward_enabled.png') no-repeat top right; }
42+.paginate_enabled_next:hover { background: url('../images/forward_enabled_hover.png') no-repeat top right; }
43+.paginate_disabled_next { background: url('../images/forward_disabled.png') no-repeat top right; }
44
45 /* Full number pagination */
46 .paging_full_numbers {
47@@ -197,12 +185,12 @@
48 /*
49 * Sorting
50 */
51-.sorting { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_both.png') no-repeat center right; }
52-.sorting_asc { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_asc.png') no-repeat center right; }
53-.sorting_desc { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_desc.png') no-repeat center right; }
54+.sorting { background: url('../images/sort_both.png') no-repeat center right; }
55+.sorting_asc { background: url('../images/sort_asc.png') no-repeat center right; }
56+.sorting_desc { background: url('../images/sort_desc.png') no-repeat center right; }
57
58-.sorting_asc_disabled { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_asc_disabled.png') no-repeat center right; }
59-.sorting_desc_disabled { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_desc_disabled.png') no-repeat center right; }
60+.sorting_asc_disabled { background: url('../images/sort_asc_disabled.png') no-repeat center right; }
61+.sorting_desc_disabled { background: url('../images/sort_desc_disabled.png') no-repeat center right; }
62
63 table.dataTable th:active {
64 outline: none;
65
66=== modified file 'common/static/css/new-style.css'
67--- common/static/css/new-style.css 2013-10-25 15:37:12 +0000
68+++ common/static/css/new-style.css 2013-12-02 13:46:27 +0000
69@@ -2,7 +2,7 @@
70 font-size : 100%;
71 }
72 body {
73- background : url("/static/images/body_bg.jpg") #fff;
74+ background : url("../images/body_bg.jpg") #fff;
75 color : #333;
76 font-family : Ubuntu, Arial, "libra sans", sans-serif;
77 font-weight : 300;
78@@ -214,7 +214,7 @@
79 margin-left : 20px;
80 top : -8px;
81 width : 200px;
82- background-image : url("/static/images/arrow-up-smaller.png");
83+ background-image : url("../images/arrow-up-smaller.png");
84 }
85 header.banner .nav-primary li ul li {
86 border : none 0;
87@@ -557,4 +557,3 @@
88 .clear {
89 clear: both;
90 }
91-
92
93=== modified file 'common/static/css/style.css'
94--- common/static/css/style.css 2013-10-25 15:37:12 +0000
95+++ common/static/css/style.css 2013-12-02 13:46:27 +0000
96@@ -196,13 +196,13 @@
97 }
98
99 .left_nav li.active {
100- background: url("//assets.ubuntu.com/sites/dashboard/img/eng_hex.svg") no-repeat;
101+ background: url("../images/eng_hex.svg") no-repeat;
102 background-size: 16px 16px;
103 background-position: left;
104 }
105
106 .error-14x14 {
107- background: url("//assets.ubuntu.com/sites/dashboard/img/activity-small-icon-vertical.png") no-repeat;
108+ background: url("../images/activity-small-icon-vertical.png") no-repeat;
109 background-position:left -14px;
110 }
111
112@@ -379,7 +379,7 @@
113 }
114
115 div.movement-up {
116- background: url("//assets.ubuntu.com/sites/dashboard/img/red-up.svg") no-repeat;
117+ background: url("../images/red-up.svg") no-repeat;
118 background-size: 20px 20px;
119 text-indent: -999px;
120 width: 100%;
121@@ -387,7 +387,7 @@
122 }
123
124 div.movement-down {
125- background: url("//assets.ubuntu.com/sites/dashboard/img/green-down.svg") no-repeat;
126+ background: url("../images/green-down.svg") no-repeat;
127 background-size: 20px 20px;
128 text-indent: -999px;
129 width: 100%;
130@@ -395,7 +395,7 @@
131 }
132
133 div.movement-up-inverse {
134- background: url("//assets.ubuntu.com/sites/dashboard/img/green-up.svg") no-repeat;
135+ background: url("../images/green-up.svg") no-repeat;
136 background-size: 20px 20px;
137 text-indent: -999px;
138 width: 100%;
139@@ -403,7 +403,7 @@
140 }
141
142 div.movement-down-inverse {
143- background: url("//assets.ubuntu.com/sites/dashboard/img/red-down.svg") no-repeat;
144+ background: url("../images/red-down.svg") no-repeat;
145 background-size: 20px 20px;
146 text-indent: -999px;
147 width: 100%;
148@@ -482,7 +482,7 @@
149 }
150
151 div.help {
152- background: url("//assets.ubuntu.com/sites/dashboard/img/help.svg") no-repeat;
153+ background: url("../images/help.svg") no-repeat;
154 background-size: 24px 24px;
155 text-indent: -999px;
156 display: inline-block;
157@@ -590,7 +590,7 @@
158 }
159
160 .list-ubuntu li {
161- background-image: url("//assets.ubuntu.com/sites/ubuntu/latest/u/img/patterns/tick-orange.png");
162+ background-image: url("../images/tick-orange.png");
163 }
164
165 ul.artifacts {
166
167=== added file 'common/static/images/tick-orange.png'
168Binary files common/static/images/tick-orange.png 1970-01-01 00:00:00 +0000 and common/static/images/tick-orange.png 2013-12-02 13:46:27 +0000 differ

Subscribers

People subscribed via source and target branches