Merge lp:~cjohnston/qa-dashboard/1246125 into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 671
Merged at revision: 670
Proposed branch: lp:~cjohnston/qa-dashboard/1246125
Merge into: lp:qa-dashboard
Diff against target: 20 lines (+3/-0)
1 file modified
smokeng/dashboard.py (+3/-0)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/1246125
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Chris Johnston Needs Resubmitting
PS Jenkins bot continuous-integration Approve
Review via email: mp+193164@code.launchpad.net

Commit message

Removing sf4p from kpi per ev

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:670
http://10.97.0.26:8080/job/dashboard-ci/241/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/241/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

seems like we should use some constant like we did for KPI_RELEASES. Not sure if it should be opt-in like KPI_VARIANTS or opt-out like KPI_VARIANT_EXCLUDES

lp:~cjohnston/qa-dashboard/1246125 updated
671. By Chris Johnston

Add KPI_VARIANT_EXCLUDES for excluding variants from KPI from Andy's review

Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'smokeng/dashboard.py'
2--- smokeng/dashboard.py 2013-10-23 16:14:41 +0000
3+++ smokeng/dashboard.py 2013-10-30 17:06:48 +0000
4@@ -31,6 +31,7 @@
5 from smokeng.tables import SmokeKPITable
6
7 KPI_RELEASES = ['precise', 'trusty']
8+KPI_VARIANT_EXCLUDES = ['touch_sf4p']
9
10
11 class SmokengPassRateKPI(KPI):
12@@ -80,6 +81,8 @@
13 image__release__in=KPI_RELEASES,
14 ).exclude(
15 image__build_number__contains='?',
16+ ).exclude(
17+ image__variant__in=KPI_VARIANT_EXCLUDES,
18 ).values(
19 'image__arch',
20 'image__variant',

Subscribers

People subscribed via source and target branches