Merge lp:~cjohnston/qa-dashboard/1243696 into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 661
Merged at revision: 660
Proposed branch: lp:~cjohnston/qa-dashboard/1243696
Merge into: lp:qa-dashboard
Diff against target: 36 lines (+3/-5)
1 file modified
smokeng/dashboard.py (+3/-5)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/1243696
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Andy Doan (community) Approve
Chris Johnston Needs Resubmitting
Review via email: mp+192349@code.launchpad.net

Commit message

Creates KPI_RELEASES for defining what releases should exist in the KPI, adds touch results back to KPI

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

we still need to remove the old hack for quantal/raring:

        skipped_releases = ['quantal', 'raring']

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:660
http://10.97.0.26:8080/job/dashboard-ci/229/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/229/rebuild

review: Approve (continuous-integration)
lp:~cjohnston/qa-dashboard/1243696 updated
661. By Chris Johnston

Remove skipped releases per review

Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Andy Doan (doanac) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:661
http://10.97.0.26:8080/job/dashboard-ci/230/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/230/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'smokeng/dashboard.py'
2--- smokeng/dashboard.py 2013-09-27 18:49:06 +0000
3+++ smokeng/dashboard.py 2013-10-23 16:14:52 +0000
4@@ -30,6 +30,8 @@
5 )
6 from smokeng.tables import SmokeKPITable
7
8+KPI_RELEASES = ['precise', 'trusty']
9+
10
11 class SmokengPassRateKPI(KPI):
12 """
13@@ -75,10 +77,9 @@
14 def _get_result_data(self):
15 qs = SmokeResult.objects.filter(
16 publish=True,
17+ image__release__in=KPI_RELEASES,
18 ).exclude(
19 image__build_number__contains='?',
20- ).exclude(
21- image__variant='touch',
22 ).values(
23 'image__arch',
24 'image__variant',
25@@ -247,11 +248,8 @@
26
27 results = self._calculate_pass_rates()
28
29- skipped_releases = ['quantal', 'raring']
30 entries = []
31 for release in sorted(results.keys(), reverse=True):
32- if release in skipped_releases:
33- continue
34 variants = results[release]
35 variant_entries = []
36 for variant in sorted(variants.keys(), reverse=True):

Subscribers

People subscribed via source and target branches