Merge lp:~cjohnston/qa-dashboard/1208654 into lp:qa-dashboard

Proposed by Chris Johnston
Status: Rejected
Rejected by: Chris Johnston
Proposed branch: lp:~cjohnston/qa-dashboard/1208654
Merge into: lp:qa-dashboard
Diff against target: 31 lines (+16/-2)
1 file modified
qa_dashboard/settings.py (+16/-2)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/1208654
Reviewer Review Type Date Requested Status
Francis Ginther Needs Fixing
PS Jenkins bot continuous-integration Approve
QA Dashboard Developers Pending
Review via email: mp+179264@code.launchpad.net

Commit message

Add formatters and filters for ci.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:566
http://s-jenkins:8080/job/dashboard-ci/148/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/148/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

These changes are not needed after removing the qa_dashboard logger and console handlers. Vote for deleting proposal.

review: Needs Fixing

Unmerged revisions

566. By Chris Johnston

Add logging stuff required by ci

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qa_dashboard/settings.py'
2--- qa_dashboard/settings.py 2013-08-06 01:04:25 +0000
3+++ qa_dashboard/settings.py 2013-08-08 19:31:24 +0000
4@@ -218,11 +218,25 @@
5 LOGGING = {
6 'version': 1,
7 'disable_existing_loggers': False,
8+ 'formatters': {
9+ 'verbose': {
10+ 'format': '%(levelname)s %(asctime)s %(module)s %(process)d '
11+ '%(thread)d %(message)s'
12+ },
13+ 'simple': {
14+ 'format': '%(levelname)s %(message)s'
15+ },
16+ },
17+ 'filters': {
18+ 'require_debug_false': {
19+ '()': 'django.utils.log.RequireDebugFalse'
20+ },
21+ },
22 'handlers': {
23 'mail_admins': {
24 'level': 'ERROR',
25- 'class': 'django.utils.log.AdminEmailHandler'
26- }
27+ 'class': 'django.utils.log.AdminEmailHandler',
28+ },
29 },
30 'loggers': {
31 'django.request': {

Subscribers

People subscribed via source and target branches