Merge lp:~cjohnston/loco-team-portal/event-recap into lp:loco-team-portal

Proposed by Chris Johnston
Status: Needs review
Proposed branch: lp:~cjohnston/loco-team-portal/event-recap
Merge into: lp:loco-team-portal
Diff against target: 218 lines (+195/-0)
3 files modified
loco_directory/events/migrations/0008_add_event_recap.py (+183/-0)
loco_directory/events/models.py (+1/-0)
loco_directory/templates/events/team_event_detail.inc.html (+11/-0)
To merge this branch: bzr merge lp:~cjohnston/loco-team-portal/event-recap
Reviewer Review Type Date Requested Status
Martin Owens (community) Needs Fixing
Review via email: mp+81925@code.launchpad.net

Commit message

Adds event recap to events pages.

To post a comment you must log in.
501. By Chris Johnston

Adds migration script

Revision history for this message
Martin Owens (doctormo) wrote :

The proposed feature works and has no technical flaws.

But the design might be a problem, we have quite a bit of text with the same styles on the page and it's not clear that the page needs the information of a simple text box that a comment or something similar would be able to provide.

Can we link instead to a blog entry or photo gallery?

review: Needs Fixing

Unmerged revisions

501. By Chris Johnston

Adds migration script

500. By Chris Johnston

Adds event recap to event pages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'loco_directory/events/migrations/0008_add_event_recap.py'
2--- loco_directory/events/migrations/0008_add_event_recap.py 1970-01-01 00:00:00 +0000
3+++ loco_directory/events/migrations/0008_add_event_recap.py 2011-11-11 02:33:24 +0000
4@@ -0,0 +1,183 @@
5+# encoding: utf-8
6+import datetime
7+from south.db import db
8+from south.v2 import SchemaMigration
9+from django.db import models
10+
11+class Migration(SchemaMigration):
12+
13+ def forwards(self, orm):
14+
15+ # Adding field 'TeamEvent.recap'
16+ db.add_column('events_teamevent', 'recap', self.gf('django.db.models.fields.TextField')(null=True, blank=True), keep_default=False)
17+
18+
19+ def backwards(self, orm):
20+
21+ # Deleting field 'TeamEvent.recap'
22+ db.delete_column('events_teamevent', 'recap')
23+
24+
25+ models = {
26+ 'auth.group': {
27+ 'Meta': {'object_name': 'Group'},
28+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
29+ 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '80'}),
30+ 'permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'})
31+ },
32+ 'auth.permission': {
33+ 'Meta': {'ordering': "('content_type__app_label', 'codename')", 'unique_together': "(('content_type', 'codename'),)", 'object_name': 'Permission'},
34+ 'codename': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
35+ 'content_type': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['contenttypes.ContentType']"}),
36+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
37+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '50'})
38+ },
39+ 'auth.user': {
40+ 'Meta': {'object_name': 'User'},
41+ 'date_joined': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
42+ 'email': ('django.db.models.fields.EmailField', [], {'max_length': '75', 'blank': 'True'}),
43+ 'first_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
44+ 'groups': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Group']", 'symmetrical': 'False', 'blank': 'True'}),
45+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
46+ 'is_active': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
47+ 'is_staff': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
48+ 'is_superuser': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
49+ 'last_login': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}),
50+ 'last_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}),
51+ 'password': ('django.db.models.fields.CharField', [], {'max_length': '128'}),
52+ 'user_permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'}),
53+ 'username': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '30'})
54+ },
55+ 'contenttypes.contenttype': {
56+ 'Meta': {'ordering': "('name',)", 'unique_together': "(('app_label', 'model'),)", 'object_name': 'ContentType', 'db_table': "'django_content_type'"},
57+ 'app_label': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
58+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
59+ 'model': ('django.db.models.fields.CharField', [], {'max_length': '100'}),
60+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '100'})
61+ },
62+ 'events.attendee': {
63+ 'Meta': {'unique_together': "(('team_event', 'attendee_profile'),)", 'object_name': 'Attendee'},
64+ 'attendee_profile': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['userprofiles.UserProfile']", 'null': 'True'}),
65+ 'guests': ('django.db.models.fields.PositiveSmallIntegerField', [], {}),
66+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
67+ 'promise': ('django.db.models.fields.CharField', [], {'max_length': '50'}),
68+ 'team_event': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['events.TeamEvent']"})
69+ },
70+ 'events.baseevent': {
71+ 'Meta': {'object_name': 'BaseEvent'},
72+ 'announce': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
73+ 'date_begin': ('django.db.models.fields.DateTimeField', [], {'db_index': 'True'}),
74+ 'date_created': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime(2011, 11, 10, 23, 46, 9, 994687)', 'db_index': 'True'}),
75+ 'date_end': ('django.db.models.fields.DateTimeField', [], {'db_index': 'True'}),
76+ 'description': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}),
77+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
78+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '150'})
79+ },
80+ 'events.globalevent': {
81+ 'Meta': {'object_name': 'GlobalEvent', '_ormbases': ['events.BaseEvent']},
82+ 'baseevent_ptr': ('django.db.models.fields.related.OneToOneField', [], {'to': "orm['events.BaseEvent']", 'unique': 'True', 'primary_key': 'True'}),
83+ 'microbloghashtag': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'}),
84+ 'pictag': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'})
85+ },
86+ 'events.teamevent': {
87+ 'Meta': {'object_name': 'TeamEvent', '_ormbases': ['events.BaseEvent']},
88+ 'baseevent_ptr': ('django.db.models.fields.related.OneToOneField', [], {'to': "orm['events.BaseEvent']", 'unique': 'True', 'primary_key': 'True'}),
89+ 'channel': ('django.db.models.fields.CharField', [], {'max_length': '25', 'null': 'True', 'blank': 'True'}),
90+ 'contact': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['userprofiles.UserProfile']", 'null': 'True'}),
91+ 'global_event': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['events.GlobalEvent']", 'null': 'True', 'blank': 'True'}),
92+ 'recap': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}),
93+ 'registration': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
94+ 'teams': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['teams.Team']", 'db_index': 'True', 'symmetrical': 'False'}),
95+ 'venue': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['venues.Venue']", 'null': 'True', 'blank': 'True'})
96+ },
97+ 'events.teameventcomment': {
98+ 'Meta': {'object_name': 'TeamEventComment'},
99+ 'comment': ('django.db.models.fields.TextField', [], {'db_index': 'True'}),
100+ 'commenter_profile': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['userprofiles.UserProfile']", 'null': 'True'}),
101+ 'date_created': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime(2011, 11, 10, 23, 46, 9, 996755)', 'db_index': 'True'}),
102+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
103+ 'team_event': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['events.TeamEvent']"})
104+ },
105+ 'teams.continent': {
106+ 'Meta': {'ordering': "('name',)", 'object_name': 'Continent'},
107+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
108+ 'name': ('django.db.models.fields.TextField', [], {'max_length': '50'})
109+ },
110+ 'teams.country': {
111+ 'Meta': {'ordering': "('name',)", 'object_name': 'Country'},
112+ 'continents': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['teams.Continent']", 'symmetrical': 'False'}),
113+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
114+ 'name': ('django.db.models.fields.TextField', [], {'max_length': '100'})
115+ },
116+ 'teams.language': {
117+ 'Meta': {'ordering': "('name',)", 'object_name': 'Language'},
118+ 'code': ('django.db.models.fields.CharField', [], {'max_length': '20', 'null': 'True'}),
119+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
120+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '150', 'null': 'True'})
121+ },
122+ 'teams.team': {
123+ 'Meta': {'ordering': "('approved', 'name')", 'object_name': 'Team', 'db_table': "'teams'"},
124+ 'active': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
125+ 'admin_profiles': ('django.db.models.fields.related.ManyToManyField', [], {'related_name': "'admins'", 'symmetrical': 'False', 'to': "orm['userprofiles.UserProfile']"}),
126+ 'approved': ('django.db.models.fields.BooleanField', [], {'default': 'False'}),
127+ 'approved_date': ('django.db.models.fields.DateField', [], {'null': 'True', 'blank': 'True'}),
128+ 'city': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'}),
129+ 'contact_profiles': ('django.db.models.fields.related.ManyToManyField', [], {'related_name': "'contacts'", 'symmetrical': 'False', 'to': "orm['userprofiles.UserProfile']"}),
130+ 'countries': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['teams.Country']", 'symmetrical': 'False'}),
131+ 'email': ('django.db.models.fields.EmailField', [], {'max_length': '75', 'null': 'True', 'blank': 'True'}),
132+ 'expires_date': ('django.db.models.fields.DateField', [], {'null': 'True', 'blank': 'True'}),
133+ 'flickr_id': ('django.db.models.fields.CharField', [], {'max_length': '20', 'null': 'True', 'blank': 'True'}),
134+ 'forum_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
135+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
136+ 'irc_chan': ('django.db.models.fields.CharField', [], {'max_length': '25', 'null': 'True', 'blank': 'True'}),
137+ 'languages': ('django.db.models.fields.related.ManyToManyField', [], {'to': "orm['teams.Language']", 'symmetrical': 'False'}),
138+ 'lp_name': ('django.db.models.fields.CharField', [], {'max_length': '40', 'null': 'True'}),
139+ 'microbloghashtag': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'}),
140+ 'ml_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
141+ 'mugshot_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
142+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '80', 'null': 'True'}),
143+ 'override_name': ('django.db.models.fields.CharField', [], {'max_length': '80', 'null': 'True', 'blank': 'True'}),
144+ 'owner_profile': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'owner'", 'null': 'True', 'to': "orm['userprofiles.UserProfile']"}),
145+ 'picasa_id': ('django.db.models.fields.CharField', [], {'max_length': '20', 'null': 'True', 'blank': 'True'}),
146+ 'pixie_id': ('django.db.models.fields.CharField', [], {'max_length': '20', 'null': 'True', 'blank': 'True'}),
147+ 'provides_support': ('django.db.models.fields.BooleanField', [], {'default': 'True'}),
148+ 'spr': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'}),
149+ 'tz': ('django.db.models.fields.CharField', [], {'default': "'UTC'", 'max_length': '32'}),
150+ 'web_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
151+ 'wiki_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'})
152+ },
153+ 'userprofiles.userprofile': {
154+ 'Meta': {'ordering': "('user__username',)", 'object_name': 'UserProfile'},
155+ 'aim': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
156+ 'blog': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'}),
157+ 'facebook': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
158+ 'flickr': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
159+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
160+ 'identica': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
161+ 'irc': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
162+ 'mugshot': ('django.db.models.fields.URLField', [], {'max_length': '150', 'null': 'True', 'blank': 'True'}),
163+ 'picasa': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
164+ 'realname': ('django.db.models.fields.CharField', [], {'max_length': '150', 'blank': 'True'}),
165+ 'twitter': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'}),
166+ 'tz': ('django.db.models.fields.CharField', [], {'default': "'UTC'", 'max_length': '32'}),
167+ 'user': ('django.db.models.fields.related.OneToOneField', [], {'to': "orm['auth.User']", 'unique': 'True'}),
168+ 'xmpp': ('django.db.models.fields.CharField', [], {'max_length': '32', 'null': 'True', 'blank': 'True'})
169+ },
170+ 'venues.venue': {
171+ 'Meta': {'unique_together': "(('name', 'country', 'city'), ('longitude', 'latitude'))", 'object_name': 'Venue'},
172+ 'address': ('django.db.models.fields.CharField', [], {'max_length': '150', 'null': 'True', 'blank': 'True'}),
173+ 'city': ('django.db.models.fields.CharField', [], {'max_length': '150', 'null': 'True', 'blank': 'True'}),
174+ 'comment': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}),
175+ 'continent': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['teams.Continent']", 'null': 'True'}),
176+ 'country': ('django.db.models.fields.related.ForeignKey', [], {'to': "orm['teams.Country']", 'null': 'True'}),
177+ 'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
178+ 'latitude': ('django.db.models.fields.FloatField', [], {'null': 'True', 'blank': 'True'}),
179+ 'longitude': ('django.db.models.fields.FloatField', [], {'null': 'True', 'blank': 'True'}),
180+ 'name': ('django.db.models.fields.CharField', [], {'max_length': '150'}),
181+ 'spr': ('django.db.models.fields.CharField', [], {'max_length': '50', 'null': 'True', 'blank': 'True'}),
182+ 'tz': ('django.db.models.fields.CharField', [], {'default': "'UTC'", 'max_length': '32'}),
183+ 'venue_url': ('django.db.models.fields.URLField', [], {'max_length': '200', 'null': 'True', 'blank': 'True'})
184+ }
185+ }
186+
187+ complete_apps = ['events']
188
189=== modified file 'loco_directory/events/models.py'
190--- loco_directory/events/models.py 2011-10-27 12:51:19 +0000
191+++ loco_directory/events/models.py 2011-11-11 02:33:24 +0000
192@@ -128,6 +128,7 @@
193 channel = models.CharField(help_text=_('Channel for the Event hosted on the freenode IRC network. Ex. #ubuntu-us-fl'), max_length=25, verbose_name=_('Event Channel'), blank=True, null=True)
194 registration = models.URLField(verbose_name=_('Registration URL'), help_text=_('URL to register attendance (leave blank to use the built-in registration system)'), max_length=200, verify_exists=False, blank=True, null=True)
195 template = 'events/team_event_li.inc.html'
196+ recap = models.TextField(verbose_name=_('Event Recap'), help_text=_('After the event, add a recap of the event.'), blank=True, null=True)
197
198 def __unicode__(self):
199 return "%s %s %s" % (self.name, self.venue, self.date_begin or "")
200
201=== modified file 'loco_directory/templates/events/team_event_detail.inc.html'
202--- loco_directory/templates/events/team_event_detail.inc.html 2010-11-27 15:04:43 +0000
203+++ loco_directory/templates/events/team_event_detail.inc.html 2011-11-11 02:33:24 +0000
204@@ -33,3 +33,14 @@
205 {% include "events/team_event_detail_comments.inc.html" %}
206 </article>
207 {% endif %}
208+
209+{% if team_event_object.recap %}
210+<article class="main-content">
211+ <h3>{% trans "Event Recap" %}</h3>
212+ <table id="team-event-basic">
213+ <tr>
214+ <td class="form-item-value">{{ team_event_object.recap|linebreaksbr|urlize }}</td>
215+ </tr>
216+ </table>
217+</article>
218+{% endif %}

Subscribers

People subscribed via source and target branches