Merge lp:~cjohnston/loco-team-portal/bugfix-lp-621498 into lp:loco-team-portal

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 255
Merged at revision: 270
Proposed branch: lp:~cjohnston/loco-team-portal/bugfix-lp-621498
Merge into: lp:loco-team-portal
Diff against target: 12 lines (+2/-0)
1 file modified
loco_directory/templates/index.html (+2/-0)
To merge this branch: bzr merge lp:~cjohnston/loco-team-portal/bugfix-lp-621498
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Needs Information
Review via email: mp+33275@code.launchpad.net

Description of the change

Removes search from main page

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Wouldn't it be a better fix to make it search for whatever people might be searching for? Events, teams, venues?

review: Needs Information
Revision history for this message
Michael Hall (mhall119) wrote :

What would the user be searching for on the main page? I'm not sure it would be efficient to search for any team, global event, team event or venue

Revision history for this message
Daniel Holbach (dholbach) wrote :

Why not? I could search for Berlin and get events and venues listed. I could search for Trinidad and get stuff listed that happens around there.

Revision history for this message
Daniel Holbach (dholbach) wrote :

It's certainly more user-friendly than having to navigate around first. :-)

Revision history for this message
Chris Johnston (cjohnston) wrote :

Before the next release, this either needs to be merged or have another fix created since right now there is a non-functioning search.

Revision history for this message
Chris Johnston (cjohnston) wrote :

There can always be a wishlist item opened up to have a working search that will search all areas.

Revision history for this message
Michael Hall (mhall119) wrote :

Created bug 628211 to add better search functionality

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/templates/index.html'
2--- loco_directory/templates/index.html 2010-08-20 02:49:29 +0000
3+++ loco_directory/templates/index.html 2010-08-21 00:45:05 +0000
4@@ -6,6 +6,8 @@
5 <a class="sub-nav-item" href="{% url using_locodir %}">{% trans "Using the LoCo Team Directory" %}</a>
6 {% endblock %}
7
8+{% block search %}{% endblock %}
9+
10 {% block extrahead %}
11 {{block.super}}
12 <link rel="stylesheet" type="text/css" href="{{MEDIA_URL}}/css/twidenash.css" />

Subscribers

People subscribed via source and target branches