Merge lp:~cjohnston/loco-team-portal/792475 into lp:loco-team-portal

Proposed by Chris Johnston
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 526
Merged at revision: 527
Proposed branch: lp:~cjohnston/loco-team-portal/792475
Merge into: lp:loco-team-portal
Diff against target: 40 lines (+2/-20)
1 file modified
loco_directory/teams/forms.py (+2/-20)
To merge this branch: bzr merge lp:~cjohnston/loco-team-portal/792475
Reviewer Review Type Date Requested Status
LoCo Team Portal Developers Pending
Review via email: mp+95799@code.launchpad.net

Commit message

Removes the ability to edit the owner and admins. Makes LTP rely on the info from LP.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/teams/forms.py'
2--- loco_directory/teams/forms.py 2011-07-22 20:09:29 +0000
3+++ loco_directory/teams/forms.py 2012-03-04 21:06:20 +0000
4@@ -10,7 +10,7 @@
5 class UpdateTeamForm(forms.ModelForm, RenderableMixin):
6 class Meta:
7 model = Team
8- exclude = ('approved_date', 'approved', 'expires_date', 'name', 'lp_name', 'admins', 'owner', 'active', 'override_name')
9+ exclude = ('approved_date', 'approved', 'expires_date', 'name', 'lp_name', 'admin_profiles', 'owner_profile', 'active', 'override_name')
10
11 class Media:
12 css = {'all': (
13@@ -19,26 +19,8 @@
14 js = (
15 '/media/js/colortip-1.0-jquery.js',
16 )
17-
18- def __init__(self, *args, **kwargs):
19- super(UpdateTeamForm, self).__init__(*args, **kwargs)
20- user_list = self.grouped_user_list()
21- self.fields['owner_profile'].choices = user_list
22- self.fields['admin_profiles'].choices = user_list
23- self.fields['contact_profiles'].choices = user_list
24-
25- def grouped_user_list(self):
26- other_members, team_members = [], []
27- for profile in UserProfile.objects.filter(user__groups__name__exact=self.instance.lp_name):
28- team_members.append((profile.id, str(profile)))
29- for profile in UserProfile.objects.all().exclude(user__groups__name__exact=self.instance.lp_name):
30- other_members.append((profile.id, str(profile)))
31-
32- return [(_('Team members'), team_members),
33- (_('Other users'), other_members)]
34-
35
36 class LoCoCouncilForm(UpdateTeamForm, RenderableMixin):
37 class Meta(UpdateTeamForm.Meta):
38 model = Team
39- exclude = ('approved', 'expires_date', 'name', 'lp_name', 'admins', 'owner', 'active')
40+ exclude = ('approved', 'expires_date', 'name', 'lp_name', 'admin_profiles', 'owner_profile', 'active')

Subscribers

People subscribed via source and target branches