Merge lp:~cjohnston/loco-team-portal/696661 into lp:loco-team-portal

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 354
Merged at revision: 363
Proposed branch: lp:~cjohnston/loco-team-portal/696661
Merge into: lp:loco-team-portal
Diff against target: 115 lines (+36/-36)
3 files modified
loco_directory/teams/models.py (+1/-1)
loco_directory/templates/teams/team_detail.html (+1/-1)
loco_directory/templates/teams/team_update.html (+34/-34)
To merge this branch: bzr merge lp:~cjohnston/loco-team-portal/696661
Reviewer Review Type Date Requested Status
Ronnie Pending
Chris Johnston Pending
Review via email: mp+45656@code.launchpad.net

This proposal supersedes a proposal from 2011-01-03.

To post a comment you must log in.
Revision history for this message
Ronnie (ronnie.vd.c) wrote : Posted in a previous version of this proposal

On the team_edit page, there is still a "Date Expires"

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) : Posted in a previous version of this proposal
review: Needs Resubmitting
Revision history for this message
Ronnie (ronnie.vd.c) wrote : Posted in a previous version of this proposal

Approved : (line 94), Date Approved : (line 99), Reapproval Date : (line 103)
still need to be translated

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) wrote : Posted in a previous version of this proposal

We have decided that translations will only be added on merges to avoid some conflicts.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/teams/models.py'
2--- loco_directory/teams/models.py 2010-12-25 08:02:40 +0000
3+++ loco_directory/teams/models.py 2011-01-10 01:00:10 +0000
4@@ -85,7 +85,7 @@
5 default=True)
6 approved = models.BooleanField(_("Approved Team"), default=False)
7 approved_date = models.DateField(_("Date Approved"), null=True, blank=True)
8- expires_date = models.DateField(_("Date Expires"), null=True, blank=True)
9+ expires_date = models.DateField(_("Reapproval Date"), null=True, blank=True)
10 owner_profile = models.ForeignKey(UserProfile, related_name='owner', null=True)
11 admin_profiles = models.ManyToManyField(UserProfile, related_name='admins')
12 contact_profiles = models.ManyToManyField(UserProfile, related_name='contacts')
13
14=== modified file 'loco_directory/templates/teams/team_detail.html'
15--- loco_directory/templates/teams/team_detail.html 2010-12-25 08:02:40 +0000
16+++ loco_directory/templates/teams/team_detail.html 2011-01-10 01:00:10 +0000
17@@ -146,7 +146,7 @@
18 {% endif %}
19 {% if team.approved %}
20 <tr>
21- <th class="form-item-label" scope="row"><label>{% trans "Expires Date:" %}</label></th>
22+ <th class="form-item-label" scope="row"><label>{% trans "Reapproval Date:" %}</label></th>
23 <td class="form-item-value">{{ team.expires_date }}</td>
24 </tr>
25 {% endif %}
26
27=== modified file 'loco_directory/templates/teams/team_update.html'
28--- loco_directory/templates/teams/team_update.html 2010-10-13 20:56:02 +0000
29+++ loco_directory/templates/teams/team_update.html 2011-01-10 01:00:10 +0000
30@@ -1,7 +1,7 @@
31 {% extends "base.html" %}
32 {% load i18n %}
33
34-{% block title %}{{ team.name }} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
35+{% block title %}Update {{ team.name }} | {% trans "Ubuntu LoCo Team Directory" %} {% endblock %}
36
37 {% block extrahead %}{{block.super}}
38 {{ form.media }}
39@@ -16,43 +16,43 @@
40 {% endblock %}
41
42 {% block sub_nav_links %}
43-<a class="sub-nav-item" href="/teams">{% trans "Back to Teams List" %}</a>
44-<a class="sub-nav-item" href="/teams/{{ team.lp_name }}">{% trans "Back to Team Details" %}</a>
45+ <a class="sub-nav-item" href="/teams">{% trans "Back to Teams List" %}</a>
46+ <a class="sub-nav-item" href="/teams/{{ team.lp_name }}">{% trans "Back to Team Details" %}</a>
47 {% endblock %}
48
49 {% block content %}
50
51- <article id="form" class="main-content">
52- {% if form.errors %}
53- <p style="color: red;">
54- {% trans "Please correct the error" %}{{ form.errors|pluralize }} below.
55- </p>
56- {% endif %}
57+ <article id="form" class="main-content">
58+ {% if form.errors %}
59+ <p style="color: red;">
60+ {% trans "Please correct the error" %}{{ form.errors|pluralize }} below.
61+ </p>
62+ {% endif %}
63
64- <form action="{{ request.path_info }}" method="POST">
65- <p>{% trans "Update the information below:" %}</p>
66- <div class="form">
67- {{ form.as_template }}
68- <div class="approved">
69- <div class="field"><label for="approved">Approved :</label></div>
70- <span class="extra">{% if team.approved %}{% trans "Yes" %}{% else %}{% trans "No" %}{% endif %}</span>
71- </div>
72- {% if team.approved %}
73- <div class="approved_date">
74- <div class="field"><label for="approved_date">Date Approved :</label></div>
75- <span class="extra">{{ team.approved_date }}</span>
76- </div>
77- <div class="expires_date">
78- <div class="field"><label for="expires_date">Date Expires :</label></div>
79- <span class="extra">{{ team.expires_date }}</span>
80- </div>
81- {% endif %}
82- <div>
83- {% if is_popup %}<input type="hidden" name="_popup" value="1">{% endif %}
84- <input type="submit" name="submit" value="{% trans "Update Information Now!" %}" class="submit-button" />
85- </div>
86- </div>
87- </form>
88-</article>
89+ <form action="{{ request.path_info }}" method="POST">
90+ <p>{% trans "Update the information below:" %}</p>
91+ <div class="form">
92+ {{ form.as_template }}
93+ <div class="approved">
94+ <div class="field"><label for="approved">Approved :</label></div>
95+ <span class="extra">{% if team.approved %}{% trans "Yes" %}{% else %}{% trans "No" %}{% endif %}</span>
96+ </div>
97+ {% if team.approved %}
98+ <div class="approved_date">
99+ <div class="field"><label for="approved_date">Date Approved :</label></div>
100+ <span class="extra">{{ team.approved_date }}</span>
101+ </div>
102+ <div class="expires_date">
103+ <div class="field"><label for="expires_date">Reapproval Date :</label></div>
104+ <span class="extra">{{ team.expires_date }}</span>
105+ </div>
106+ {% endif %}
107+ <div>
108+ {% if is_popup %}<input type="hidden" name="_popup" value="1">{% endif %}
109+ <input type="submit" name="submit" value="{% trans "Update Information Now!" %}" class="submit-button" />
110+ </div>
111+ </div>
112+ </form>
113+ </article>
114
115 {% endblock %}

Subscribers

People subscribed via source and target branches