Merge lp:~cjohnston/loco-team-portal/1019665 into lp:loco-team-portal

Proposed by Chris Johnston
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 540
Merged at revision: 542
Proposed branch: lp:~cjohnston/loco-team-portal/1019665
Merge into: lp:loco-team-portal
Diff against target: 69 lines (+19/-20)
3 files modified
loco_directory/templates/events/team_event_comment_new.inc.html (+2/-2)
loco_directory/templates/events/team_event_detail.html (+0/-18)
loco_directory/templates/events/team_event_detail.inc.html (+17/-0)
To merge this branch: bzr merge lp:~cjohnston/loco-team-portal/1019665
Reviewer Review Type Date Requested Status
LoCo Team Portal Developers Pending
Review via email: mp+112917@code.launchpad.net

Commit message

Moves social stuff above comments, fixes links that appear when not logged in

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/templates/events/team_event_comment_new.inc.html'
2--- loco_directory/templates/events/team_event_comment_new.inc.html 2012-06-30 19:58:08 +0000
3+++ loco_directory/templates/events/team_event_comment_new.inc.html 2012-06-30 23:43:17 +0000
4@@ -18,7 +18,7 @@
5
6 <div class="row">
7 <section class="span-8">
8- {% blocktrans with team_event_object.get_absolute_url as login_next %}To post your comment you need to <a href="openid/login/?next={{ login_next }}">login</a> or <a href="openid/login/?next={{ login_next }}">create</a> a new account{% endblocktrans %}
9+ {% blocktrans with team_event_object.get_absolute_url as login_next %}To post your comment you need to <a href="/openid/login?next={{login_next}}">login</a> or <a href="/openid/login/?next={{ login_next }}">create</a> a new account{% endblocktrans %}
10 </section>
11 </div>
12-{% endif %}
13\ No newline at end of file
14+{% endif %}
15
16=== modified file 'loco_directory/templates/events/team_event_detail.html'
17--- loco_directory/templates/events/team_event_detail.html 2012-06-30 19:41:40 +0000
18+++ loco_directory/templates/events/team_event_detail.html 2012-06-30 23:43:17 +0000
19@@ -48,22 +48,4 @@
20
21 {% include "events/team_event_detail.inc.html" %}
22
23-<div class="share">
24- <a href="http://www.reddit.com/submit" onclick="window.location = 'http://www.reddit.com/submit?url=' + encodeURIComponent(window.location); return false"> <img style="padding-bottom: 4px;"src="http://www.reddit.com/static/spreddit7.gif" alt="submit to reddit" border="0" /></a><br />
25- <div id="fb-root"></div>
26- <script>(function(d, s, id) {
27- var js, fjs = d.getElementsByTagName(s)[0];
28- if (d.getElementById(id)) {return;}
29- js = d.createElement(s); js.id = id;
30- js.src = "//connect.facebook.net/en_US/all.js#xfbml=1&appId=127188230723188";
31- fjs.parentNode.insertBefore(js, fjs);
32- }(document, 'script', 'facebook-jssdk'));</script>
33- <div class="fb-like" data-href="http://loco.ubuntu.com{% url team-event-detail team_event_object.first_team.lp_name team_event_object.id %}" data-send="false" data-layout="box_count" data-width="40" data-show-faces="false" data-font="arial"></div>
34- <script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>
35- <g:plusone size="tall"></g:plusone>
36- <a href="http://twitter.com/share" class="twitter-share-button" data-count="vertical" data-lang="en">Tweet</a>
37- <script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script>
38- <script src="http://www.stumbleupon.com/hostedbadge.php?s=5"></script>
39-</div>
40-
41 {% endblock %}
42
43=== modified file 'loco_directory/templates/events/team_event_detail.inc.html'
44--- loco_directory/templates/events/team_event_detail.inc.html 2012-06-30 19:19:08 +0000
45+++ loco_directory/templates/events/team_event_detail.inc.html 2012-06-30 23:43:17 +0000
46@@ -11,6 +11,23 @@
47 {% endif %}
48 <h3>{% trans "Details" %}</h3>
49 {% include "events/team_event_detail_basic.inc.html" %}
50+ <div class="share">
51+ <a href="http://www.reddit.com/submit" onclick="window.location = 'http://www.reddit.com/submit?url=' + encodeURIComponent(window.location); return false"> <img style="padding-bottom: 4px;"src="http://www.reddit.com/static/spreddit7.gif" alt="submit to reddit" border="0" /></a><br />
52+ <div id="fb-root"></div>
53+ <script>(function(d, s, id) {
54+ var js, fjs = d.getElementsByTagName(s)[0];
55+ if (d.getElementById(id)) {return;}
56+ js = d.createElement(s); js.id = id;
57+ js.src = "//connect.facebook.net/en_US/all.js#xfbml=1&appId=127188230723188";
58+ fjs.parentNode.insertBefore(js, fjs);
59+ }(document, 'script', 'facebook-jssdk'));</script>
60+ <div class="fb-like" data-href="http://loco.ubuntu.com{% url team-event-detail team_event_object.first_team.lp_name team_event_object.id %}" data-send="false" data-layout="box_count" data-width="40" data-show-faces="false" data-font="arial"></div>
61+ <script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>
62+ <g:plusone size="tall"></g:plusone>
63+ <a href="http://twitter.com/share" class="twitter-share-button" data-count="vertical" data-lang="en">Tweet</a>
64+ <script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script>
65+ <script src="http://www.stumbleupon.com/hostedbadge.php?s=5"></script>
66+</div>
67 </section>
68 <section class="span-6 last">
69 <h3>

Subscribers

People subscribed via source and target branches