Merge lp:~cjohnston/launchpad/ic-js-cleanup into lp:launchpad

Proposed by Chris Johnston
Status: Merged
Merged at revision: 17012
Proposed branch: lp:~cjohnston/launchpad/ic-js-cleanup
Merge into: lp:launchpad
Prerequisite: lp:~wgrant/launchpad/ic-js-cleanup
Diff against target: 71 lines (+32/-3)
2 files modified
lib/canonical/launchpad/icing/style.css (+29/-3)
lib/lp/code/templates/branchmergeproposal-index.pt (+3/-0)
To merge this branch: bzr merge lp:~cjohnston/launchpad/ic-js-cleanup
Reviewer Review Type Date Requested Status
Chris Johnston (community) Needs Resubmitting
William Grant Needs Information
Review via email: mp+220301@code.launchpad.net

Commit message

Fix CSS related issues with wgrant's ic-js-cleanup branch.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Needs Information
Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Chris Johnston (cjohnston) :
Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style.css'
2--- lib/canonical/launchpad/icing/style.css 2014-05-20 20:52:45 +0000
3+++ lib/canonical/launchpad/icing/style.css 2014-05-20 20:52:45 +0000
4@@ -584,6 +584,7 @@
5 table.diff {
6 white-space: pre-wrap;
7 width: 100%;
8+ table-layout: fixed;
9 background-color: white;
10 margin-bottom: 0.5em;
11 }
12@@ -593,17 +594,42 @@
13 background-color: #f6f6f6;
14 color: #999;
15 border-right: solid 4px white;
16+ width: 5%;
17 }
18 table.diff .line-no.active {
19- background: url(/@@/edit) #f6f6f6 center left no-repeat;
20+ background: url(/@@/add) #f6f6f6 center left no-repeat;
21 }
22 table.diff .diff-chunk, table.diff .diff-file, table.diff .diff-header {
23 font-weight: bold;
24 }
25 table.diff .diff-added { background-color: #92ED92; }
26 table.diff .diff-removed { background-color: #FF7F7F; }
27-table.diff .inline-comments > td > div { margin: 0px 1em; }
28-
29+table.diff .inline-comments > td > div {
30+ margin: 0px 1em;
31+ word-wrap: break-word;
32+ font-family: monospace;
33+}
34+table.diff .inline-comments .yui3-ieditor { padding-right:0!important; }
35+table.diff .inline-comments .yui3-ieditor-multiline .yui3-ieditor-btns .bg-top-label button.lazr-btn {
36+ word-wrap: normal;
37+}
38+table.diff .inline-comments .yui3-ieditor-multiline .yui3-ieditor-btns .bg-top-label {
39+ background-image: none!important;
40+ margin-right: -7px!important;
41+ margin-top: 18px!important;
42+}
43+table.diff .inline-comments .yui3-ieditor-input textarea {
44+ width: 92%;
45+ max-width: 92%;
46+ float: left;
47+}
48+table.diff .inline-comments .yui3-ieditor-input {
49+ width: auto!important;
50+ margin-right: 0;
51+ margin-bottom: 5px;
52+ overflow: hidden;
53+}
54+
55 .back-link { margin-top: 3em; }
56
57 .reviews {
58
59=== modified file 'lib/lp/code/templates/branchmergeproposal-index.pt'
60--- lib/lp/code/templates/branchmergeproposal-index.pt 2014-05-14 00:48:31 +0000
61+++ lib/lp/code/templates/branchmergeproposal-index.pt 2014-05-20 20:52:45 +0000
62@@ -36,6 +36,9 @@
63 #add-comment-review-fields div {
64 display: inline;
65 }
66+ .yui3-publishdrafts {
67+ padding-left: 3px;
68+ }
69 #proposal-summary th {
70 font-weight: bold;
71 color: #717171;