Merge lp:~cjohnston/launchpad/fix-word-break into lp:launchpad

Proposed by Celso Providelo
Status: Rejected
Rejected by: William Grant
Proposed branch: lp:~cjohnston/launchpad/fix-word-break
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/code/browser/codereviewcomment.py (+1/-1)
To merge this branch: bzr merge lp:~cjohnston/launchpad/fix-word-break
Reviewer Review Type Date Requested Status
Celso Providelo Pending
Review via email: mp+219285@code.launchpad.net

This proposal supersedes a proposal from 2014-05-12.

Description of the change

- Set publish inline comments to true by default

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote : Posted in a previous version of this proposal

Thanks for working on this.

I have only on minor comment about replacing L.insert(0,...) for a append(''); extend(...); append('')

Once that's done we can land it.

review: Approve
Revision history for this message
William Grant (wgrant) wrote :

Superseded by cprov's rework of that checkbox.

Unmerged revisions

17007. By Chris Johnston

Check publish inline comments by default

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/browser/codereviewcomment.py'
2--- lib/lp/code/browser/codereviewcomment.py 2014-04-04 05:23:48 +0000
3+++ lib/lp/code/browser/codereviewcomment.py 2014-05-13 04:29:27 +0000
4@@ -259,7 +259,7 @@
5 comment = self.reply_to.as_quoted_email
6 else:
7 comment = ''
8- return {'comment': comment}
9+ return {'comment': comment, 'publish_inline_comments': True}
10
11 def setUpFields(self):
12 super(CodeReviewCommentAddView, self).setUpFields()