Merge lp:~cjohnston/launchpad/883258 into lp:launchpad

[Chris Johnston]

Increase the Ubuntu Mono font size for better readability.

Looking at the various platforms like GitHub, Google, and Gnome Bugzilla, it is much harder to read the text on Launchpad than it is on these other sites. This is caused by the design and use of the Ubuntu Mono font. A more detailed report about the differences is given in the bug. Adding the Ubuntu Mono web font to Launchpad allows for the Ubuntu Mono font size to be increased to a size where it has better readability.

[Matthew Paul Thomas (mpt)]

As described in my original bug report, I think Launchpad would be better off not using the Ubuntu Mono font at all. At *any* size, it is less readable than most other monospace fonts at the same size -- including those typically used by default in browsers -- because of its smaller x-height and its use of shapes intended for a proportional font. There is no branding argument for its use: Launchpad doesn't share Ubuntu branding generally, and even if it did, Ubuntu branding is far more strongly associated with the proportional Ubuntu font than with Ubuntu Mono. And while Web fonts in general are cool, the lag and/or flicker involved would be a poor tradeoff for a code-hosting site even if we were importing the best-designed monospace font in the world.

Chris has told me there is a belief that switching away from the Ubuntu Mono font would "screw up comments formatting for old comments". I don't see how this could be true, for three reasons. First, comments have always wrapped to suit your browser width, so comment authors have never been able to assume a particular line length. Second, if changing the typeface would be a problem, the fact that Launchpad users without the font installed currently don't see it would already be a problem, which (as far as I know) it is not. And third, if changing the typeface would be a problem, changing it at all in 2011 would also have been a problem, but while the choice of font was a problem, the fact that it changed at all was not.

[William Grant (wgrant)]

I said we couldn't switch to a proportional font, not that we couldn't switch away from Ubuntu Mono. The latter probably makes sense at this point.

[Chris Johnston (cjohnston)]

Rejecting in favor of https://code.launchpad.net/~cjohnston/launchpad/883258-monospace/+merge/219481

review: Disapprove

=== modified file 'lib/canonical/launchpad/icing/css/modifiers.css'
--- lib/canonical/launchpad/icing/css/modifiers.css	2013-04-22 06:20:18 +0000
+++ lib/canonical/launchpad/icing/css/modifiers.css	2014-04-11 02:04:39 +0000
@@ -170,6 +170,7 @@
 .comment-text,
 .bug-activity {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     }
 
 .cloud-size-smallest {

=== modified file 'lib/canonical/launchpad/icing/css/typography.css'
--- lib/canonical/launchpad/icing/css/typography.css	2012-09-12 01:36:22 +0000
+++ lib/canonical/launchpad/icing/css/typography.css	2014-04-11 02:04:39 +0000
@@ -42,6 +42,7 @@
     }
 pre, code, samp, tt, .console {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     margin-bottom: 0.8em;
     }
 pre.wrap {

=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css	2013-09-05 03:57:28 +0000
+++ lib/canonical/launchpad/icing/style.css	2014-04-11 02:04:39 +0000
@@ -28,6 +28,7 @@
 div#edit-description,
 div#edit-commit_message {
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     margin: 1em 0;
     }
 
@@ -486,6 +487,7 @@
     border: solid gray;
     border-width: 1px;
     font-family: 'Ubuntu Mono', monospace;
+    font-size: 14px;
     border-radius: 5px;
 }
 

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2012-08-22 17:38:03 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2014-04-11 02:04:39 +0000
@@ -14,6 +14,7 @@
     }
     div#edit-recipe_text, div#edit-description {
       font-family: "Ubuntu Mono",monospace;
+      font-size: 14px;
       margin: 1em 0;
     }
     div#edit-recipe_text.yui3-editable_text-content,