Merge lp:~cjohnston/launchpad/883258 into lp:launchpad

Proposed by Chris Johnston
Status: Rejected
Rejected by: William Grant
Proposed branch: lp:~cjohnston/launchpad/883258
Merge into: lp:launchpad
Prerequisite: lp:~cjohnston/launchpad/918284
Diff against target: 55 lines (+5/-0)
4 files modified
lib/canonical/launchpad/icing/css/modifiers.css (+1/-0)
lib/canonical/launchpad/icing/css/typography.css (+1/-0)
lib/canonical/launchpad/icing/style.css (+2/-0)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+1/-0)
To merge this branch: bzr merge lp:~cjohnston/launchpad/883258
Reviewer Review Type Date Requested Status
Chris Johnston (community) Disapprove
Launchpad code reviewers Pending
Review via email: mp+215332@code.launchpad.net

Commit message

Increase the Ubuntu Mono font size for better readability.

Description of the change

Looking at the various platforms like GitHub, Google, and Gnome Bugzilla, it is much harder to read the text on Launchpad than it is on these other sites. This is caused by the design and use of the Ubuntu Mono font. A more detailed report about the differences is given in the bug. Adding the Ubuntu Mono web font to Launchpad allows for the Ubuntu Mono font size to be increased to a size where it has better readability.

To post a comment you must log in.
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

As described in my original bug report, I think Launchpad would be better off not using the Ubuntu Mono font at all. At *any* size, it is less readable than most other monospace fonts at the same size -- including those typically used by default in browsers -- because of its smaller x-height and its use of shapes intended for a proportional font. There is no branding argument for its use: Launchpad doesn't share Ubuntu branding generally, and even if it did, Ubuntu branding is far more strongly associated with the proportional Ubuntu font than with Ubuntu Mono. And while Web fonts in general are cool, the lag and/or flicker involved would be a poor tradeoff for a code-hosting site even if we were importing the best-designed monospace font in the world.

Chris has told me there is a belief that switching away from the Ubuntu Mono font would "screw up comments formatting for old comments". I don't see how this could be true, for three reasons. First, comments have always wrapped to suit your browser width, so comment authors have never been able to assume a particular line length. Second, if changing the typeface would be a problem, the fact that Launchpad users without the font installed currently don't see it would already be a problem, which (as far as I know) it is not. And third, if changing the typeface would be a problem, changing it at all in 2011 would also have been a problem, but while the choice of font was a problem, the fact that it changed at all was not.

Revision history for this message
William Grant (wgrant) wrote :

I said we couldn't switch to a proportional font, not that we couldn't switch away from Ubuntu Mono. The latter probably makes sense at this point.

Revision history for this message
Chris Johnston (cjohnston) wrote :
review: Disapprove

Unmerged revisions

16986. By Chris Johnston

Increase the font-size of the Ubuntu Mono font

16985. By Chris Johnston

Add Ubuntu Mono web font

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/css/modifiers.css'
2--- lib/canonical/launchpad/icing/css/modifiers.css 2013-04-22 06:20:18 +0000
3+++ lib/canonical/launchpad/icing/css/modifiers.css 2014-04-11 02:04:39 +0000
4@@ -170,6 +170,7 @@
5 .comment-text,
6 .bug-activity {
7 font-family: 'Ubuntu Mono', monospace;
8+ font-size: 14px;
9 }
10
11 .cloud-size-smallest {
12
13=== modified file 'lib/canonical/launchpad/icing/css/typography.css'
14--- lib/canonical/launchpad/icing/css/typography.css 2012-09-12 01:36:22 +0000
15+++ lib/canonical/launchpad/icing/css/typography.css 2014-04-11 02:04:39 +0000
16@@ -42,6 +42,7 @@
17 }
18 pre, code, samp, tt, .console {
19 font-family: 'Ubuntu Mono', monospace;
20+ font-size: 14px;
21 margin-bottom: 0.8em;
22 }
23 pre.wrap {
24
25=== modified file 'lib/canonical/launchpad/icing/style.css'
26--- lib/canonical/launchpad/icing/style.css 2013-09-05 03:57:28 +0000
27+++ lib/canonical/launchpad/icing/style.css 2014-04-11 02:04:39 +0000
28@@ -28,6 +28,7 @@
29 div#edit-description,
30 div#edit-commit_message {
31 font-family: 'Ubuntu Mono', monospace;
32+ font-size: 14px;
33 margin: 1em 0;
34 }
35
36@@ -486,6 +487,7 @@
37 border: solid gray;
38 border-width: 1px;
39 font-family: 'Ubuntu Mono', monospace;
40+ font-size: 14px;
41 border-radius: 5px;
42 }
43
44
45=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
46--- lib/lp/code/templates/sourcepackagerecipe-index.pt 2012-08-22 17:38:03 +0000
47+++ lib/lp/code/templates/sourcepackagerecipe-index.pt 2014-04-11 02:04:39 +0000
48@@ -14,6 +14,7 @@
49 }
50 div#edit-recipe_text, div#edit-description {
51 font-family: "Ubuntu Mono",monospace;
52+ font-size: 14px;
53 margin: 1em 0;
54 }
55 div#edit-recipe_text.yui3-editable_text-content,