Merge lp:~cjohnston/launchpad/812225 into lp:launchpad

Proposed by Chris Johnston
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 16980
Proposed branch: lp:~cjohnston/launchpad/812225
Merge into: lp:launchpad
Diff against target: 49 lines (+5/-5)
3 files modified
lib/lp/bugs/browser/bug.py (+2/-2)
lib/lp/bugs/stories/bug-also-affects/xx-request-distribution-no-release-fix.txt (+2/-2)
lib/lp/bugs/stories/bugs/xx-edit-no-currentrelease-distribution-task.txt (+1/-1)
To merge this branch: bzr merge lp:~cjohnston/launchpad/812225
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+214306@code.launchpad.net

Commit message

Add package as an 'also affects' on bug reports

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Chris,

Thanks for re-wording this. It will possibly alleviate some confusing on bug-filing as suggested in the bug report, but IMHO it doesn't address the underlying issue as required by #1334.

My only concern is that this small change calls people's attention to #1334 when we are not prepared to act on it. It will require explanations that would not be requested otherwise.

OTOH, I am not strongly opposed to landing, since it hardly affects the way ubuntu users/developers use LP Bugs and it is only marginally helpful for unexperienced users, who are very likely to mis-assign bugs no matter what we do (unified two-phase reporting is the only thing that would probably help).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/bug.py'
2--- lib/lp/bugs/browser/bug.py 2014-02-26 04:41:31 +0000
3+++ lib/lp/bugs/browser/bug.py 2014-04-04 16:30:28 +0000
4@@ -260,8 +260,8 @@
5 return Link('+choose-affected-product', text, icon='add')
6
7 def adddistro(self):
8- """Return the 'Also affects distribution' Link."""
9- text = 'Also affects distribution'
10+ """Return the 'Also affects distribution/package' Link."""
11+ text = 'Also affects distribution/package'
12 return Link('+distrotask', text, icon='add')
13
14 def subscription(self):
15
16=== modified file 'lib/lp/bugs/stories/bug-also-affects/xx-request-distribution-no-release-fix.txt'
17--- lib/lp/bugs/stories/bug-also-affects/xx-request-distribution-no-release-fix.txt 2009-06-12 16:36:02 +0000
18+++ lib/lp/bugs/stories/bug-also-affects/xx-request-distribution-no-release-fix.txt 2014-04-04 16:30:28 +0000
19@@ -16,7 +16,7 @@
20 Any user can request a fix for it.
21
22 >>> user_browser.open('http://launchpad.dev/bugs/4')
23- >>> user_browser.getLink('Also affects distribution').click()
24+ >>> user_browser.getLink('Also affects distribution/package').click()
25 >>> user_browser.getControl('Distribution').value = ['gentoo']
26 >>> user_browser.getControl('Continue').click()
27 >>> user_browser.url
28@@ -36,7 +36,7 @@
29 False
30
31 >>> user_browser.open('http://launchpad.dev/bugs/7')
32- >>> user_browser.getLink('Also affects distribution').click()
33+ >>> user_browser.getLink('Also affects distribution/package').click()
34 >>> user_browser.getControl('Distribution').value = ['gentoo']
35 >>> user_browser.getControl('Source Package').value = ''
36 >>> user_browser.getControl('URL').value = (
37
38=== modified file 'lib/lp/bugs/stories/bugs/xx-edit-no-currentrelease-distribution-task.txt'
39--- lib/lp/bugs/stories/bugs/xx-edit-no-currentrelease-distribution-task.txt 2009-06-12 16:36:02 +0000
40+++ lib/lp/bugs/stories/bugs/xx-edit-no-currentrelease-distribution-task.txt 2014-04-04 16:30:28 +0000
41@@ -5,7 +5,7 @@
42 tasks currently open, so let's add one.
43
44 >>> user_browser.open('http://launchpad.dev/bugs/4')
45- >>> user_browser.getLink('Also affects distribution').click()
46+ >>> user_browser.getLink('Also affects distribution/package').click()
47
48 >>> user_browser.getControl('Distribution').value = ['gentoo']
49 >>> user_browser.getControl('Continue').click()