Launchpad itself

Merge lp:~cjohnston/launchpad/432983 into lp:launchpad

  1. 432983
  2. Merge into devel
Proposed by Chris Johnston
Status: Merged
Merged at revision: 13071
Proposed branch: lp:~cjohnston/launchpad/432983
Merge into: lp:launchpad
Diff against target: 11 lines (+3/-0)
1 file modified
lib/canonical/launchpad/webapp/error.py (+3/-0)
To merge this branch: bzr merge lp:~cjohnston/launchpad/432983
Reviewer Review Type Date Requested Status
William Grant Needs Fixing
Review via email: mp+61048@code.launchpad.net
To post a comment you must log in.
Revision history for this message
William Grant (wgrant) wrote :

Thanks for fixing one of my oldish bugs!

However, I see that you've changed NoReferrerErrorView, rather than UnauthorizedView. NoReferrerErrorView probably wants a different title, with UnauthorizedView saying "Error: Forbidden" instead.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/webapp/error.py'
2--- lib/canonical/launchpad/webapp/error.py 2011-04-19 04:17:54 +0000
3+++ lib/canonical/launchpad/webapp/error.py 2011-05-15 23:09:32 +0000
4@@ -293,4 +293,7 @@
5 class NoReferrerErrorView(SystemErrorView):
6 """View rendered when a POST request does not include a REFERER header."""
7
8+ page_title = "Error: Forbidden"
9+ override_title_breadcrumbs = True
10+
11 response_code = 403 # Forbidden.