Merge lp:~cjohnston/launchpad/1324486 into lp:launchpad

Proposed by Chris Johnston
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 17025
Proposed branch: lp:~cjohnston/launchpad/1324486
Merge into: lp:launchpad
Diff against target: 35 lines (+10/-4)
2 files modified
lib/lp/app/javascript/ui/banner.js (+9/-3)
lib/lp/services/features/flags.py (+1/-1)
To merge this branch: bzr merge lp:~cjohnston/launchpad/1324486
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+221410@code.launchpad.net

Commit message

Add the ability to not have a 'read more' in the beta banner, remove link from beta banner for IC

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/app/javascript/ui/banner.js'
2--- lib/lp/app/javascript/ui/banner.js 2012-11-09 18:55:02 +0000
3+++ lib/lp/app/javascript/ui/banner.js 2014-05-29 15:09:32 +0000
4@@ -226,9 +226,15 @@
5 content = content + [
6 '<span class="beta-feature">',
7 obj.title,
8- '&nbsp;<a class="info-link" href="',
9- obj.url + '">(read more)</a>',
10- '</span>'
11+ ].join('')
12+ if (obj.url !== '') {
13+ content = content + [
14+ '&nbsp;<a class="info-link" href="',
15+ obj.url + '">(read more)</a>',
16+ ].join('')
17+ }
18+ content = content + [
19+ '</span>'
20 ].join('');
21 }
22 }
23
24=== modified file 'lib/lp/services/features/flags.py'
25--- lib/lp/services/features/flags.py 2014-05-28 22:03:06 +0000
26+++ lib/lp/services/features/flags.py 2014-05-29 15:09:32 +0000
27@@ -226,7 +226,7 @@
28 'If true, reviewers can comment on parts of merge proposal diffs.',
29 'disabled',
30 'Inline diff comments',
31- 'http://blog.launchpad.net/general/diff-comments'),
32+ ''),
33 ])
34
35 # The set of all flag names that are documented.