Launchpad itself

Merge lp:~cjohnston/launchpad/1244636 into lp:launchpad

  1. 1244636
  2. Merge into devel
Proposed by Chris Johnston
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 16973
Proposed branch: lp:~cjohnston/launchpad/1244636
Merge into: lp:launchpad
Diff against target: 20 lines (+1/-2)
1 file modified
lib/lp/bugs/browser/bugtarget.py (+1/-2)
To merge this branch: bzr merge lp:~cjohnston/launchpad/1244636
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+213574@code.launchpad.net

Commit message

Removes the private security bug notice from a public security bug

Description of the change

Currently Launchpad shows a message about security bugs being private by default even when reporting a public security bug. This is confusing behavior.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/bugtarget.py'
2--- lib/lp/bugs/browser/bugtarget.py 2014-02-24 06:50:46 +0000
3+++ lib/lp/bugs/browser/bugtarget.py 2014-04-01 03:43:26 +0000
4@@ -63,7 +63,6 @@
5 InformationType,
6 PRIVATE_INFORMATION_TYPES,
7 PUBLIC_INFORMATION_TYPES,
8- SECURITY_INFORMATION_TYPES,
9 ServiceUsage,
10 )
11 from lp.app.errors import (
12@@ -640,7 +639,7 @@
13 # Give the user some feedback on the bug just opened.
14 for notification in notifications:
15 self.request.response.addNotification(notification)
16- if bug.information_type in SECURITY_INFORMATION_TYPES:
17+ if bug.information_type == InformationType.PRIVATESECURITY:
18 self.request.response.addNotification(
19 structured(
20 'Security-related bugs are by default private '