Merge lp:~cjohnston/launchpad-work-items-tracker/no-crash-on-404 into lp:launchpad-work-items-tracker

[Chris Johnston]

The collect script will error and give a traceback when a 404 is received from the LP API. This allow the script to continue after getting a 404.

[Martin Pitt (pitti)]

This is a crash that "Should Not Happen"™. Can you find out the URL that crashes and report a bug against Launchpad for this?

As a workaround this looks good to me, thanks!

review: Approve

=== modified file 'lpworkitems/collect.py'
--- lpworkitems/collect.py	2011-12-06 15:20:43 +0000
+++ lpworkitems/collect.py	2013-01-18 16:49:21 +0000
@@ -1,6 +1,8 @@
 import datetime
 import urllib
 
+from lazr.restfulclient.errors import NotFound
+
 from lpworkitems import models
 from lpworkitems.error_collector import MilestoneError
 
@@ -313,7 +315,10 @@
 
     def get_workitem_if_tracked(self, task, projects=None,
                                 distro_release=None):
-        target = self.lp.load(task.target.self_link)
+        try:
+            target = self.lp.load(task.target.self_link)
+        except NotFound:
+            return None
         def get_rtype(obj):
             return urllib.splittag(obj.resource_type_link)[1]
         rtype = get_rtype(target)
@@ -353,7 +358,10 @@
                     return None
             if rtype == self.DISTRIBUTION_SOURCE_PACKAGE_RTYPE:
                 for subtask in task.related_tasks:
-                    subtarget = self.lp.load(subtask.target.self_link)
+                    try:
+                        subtarget = self.lp.load(subtask.target.self_link)
+                    except NotFound:
+                        return None
                     sub_rtype = get_rtype(subtarget)
                     if sub_rtype == self.SOURCE_PACKAGE_RTYPE:
                         distro_name = (