Merge lp:~cjohnston/launchpad-work-items-tracker/get-bug-assignee into lp:launchpad-work-items-tracker

[Chris Johnston]

Find assignee of the bug and assign it to them.

One way to create work items is to link bugs to tracked blueprints. If the bug is not filed under a tracked project however, there are issues with getting the assignee for the bug. Currently, it just defaults the assignee to whomever is assigned the blueprint. This MP attempts to fix that by checking to see if the bug has a proper assignee, and if so assigns that assignee, otherwise it will continue to assign the assignee of the blueprint.

[Martin Pitt (pitti)]

The general logic is fine, but I would advise against bare "except:" statements. This will catch any and all exception, even those which would otherwise point out blatant errors in the code such as NameError, SyntaxError, or AttributeError. You can easily and silently break the complete try: block with that. I suggest to rather just except the classes that can realistically happen, and have it actually crash on an unexpected exception.

[lp:~cjohnston/launchpad-work-items-tracker/get-bug-assignee]

314. By Chris Johnston on 2013-06-21

Uses better logic for getting bug assignee

[Chris Johnston (cjohnston)]

review: Needs Resubmitting

[Martin Pitt (pitti)]

Looks better, thanks!

review: Approve

=== modified file 'lpworkitems/collect.py'
--- lpworkitems/collect.py	2013-01-18 16:42:37 +0000
+++ lpworkitems/collect.py	2013-06-21 13:24:25 +0000
@@ -420,7 +420,11 @@
                 return []
             workitem = models.Workitem()
             workitem.description = self.get_description(bug)
-            workitem.assignee_name = self.blueprint.assignee_name
+            if task.assignee_link is None:
+                workitem.assignee_name = self.blueprint.assignee_name
+            else:
+                workitem.assignee_name = models.extract_user_name_from_url(
+                    task.assignee_link)
             workitem.milestone_name = self.blueprint.milestone_name
             workitem.status = all_tasks_workitem_state
             workitem.blueprint = self.blueprint