Merge lp:~cjohnston/helipad/ci-django-15-urls into lp:helipad/ci

Proposed by Chris Johnston
Status: Merged
Approved by: Francis Ginther
Approved revision: 45
Merged at revision: 45
Proposed branch: lp:~cjohnston/helipad/ci-django-15-urls
Merge into: lp:helipad/ci
Diff against target: 146 lines (+19/-18)
5 files modified
templates/ci/daily_release_overview.html (+4/-5)
templates/ci/job.html (+2/-1)
templates/ci/project_detail.html (+4/-4)
templates/ci/project_list.html (+4/-3)
templates/ci/stack_list.html (+5/-5)
To merge this branch: bzr merge lp:~cjohnston/helipad/ci-django-15-urls
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Francis Ginther Approve
Review via email: mp+186672@code.launchpad.net

Commit message

Updates URLs to work with django 1.5

Description of the change

As we are looking forward to upgrading django to 1.5, we need to ensure that the URLs work for django 1.5

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Verified that all urls are moved to the new format as documented here:
https://docs.djangoproject.com/en/dev/releases/1.5/

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/ci/daily_release_overview.html'
2--- templates/ci/daily_release_overview.html 2013-08-01 17:52:24 +0000
3+++ templates/ci/daily_release_overview.html 2013-09-19 21:57:04 +0000
4@@ -1,7 +1,6 @@
5 {% extends "ci/ci_layout.html" %}
6-{% load dashboard_extras %}
7-{% load ci_extras %}
8-{% load percentage %}
9+{% load url from future %}
10+{% load dashboard_extras ci_extras percentage %}
11
12 {% block page_name %}Daily release status for {% if show_filter %}{{ show_filter }}{% else %}all stacks{% endif %}{% endblock %}
13
14@@ -31,11 +30,11 @@
15 </h3>
16 <ul class='left_nav'>
17 <li>
18- <a href='{% url ci_daily_overview %}'>All</a>
19+ <a href='{% url "ci_daily_overview" %}'>All</a>
20 </li>
21 {% for release in release_list %}
22 <li>
23- <a href='{% url ci_daily_overview %}?show={{ release }} '>{{ release }}</a>
24+ <a href='{% url "ci_daily_overview" %}?show={{ release }} '>{{ release }}</a>
25 </li>
26 {% endfor %}
27 </ul>
28
29=== modified file 'templates/ci/job.html'
30--- templates/ci/job.html 2013-07-29 21:52:02 +0000
31+++ templates/ci/job.html 2013-09-19 21:57:04 +0000
32@@ -1,4 +1,5 @@
33 {% extends "layout.html" %}
34+{% load url from future %}
35 {% load dashboard_extras %}
36
37 {% block page_name %}Upstream merger builds for {{ job.name }}{% endblock %}
38@@ -29,7 +30,7 @@
39 </li>
40 {% for result in result_list %}
41 <li>
42- <a href='{% url ci_job job.name %}?show={{ result.name }}'>{{ result.name }}</a>
43+ <a href='{% url "ci_job" job.name %}?show={{ result.name }}'>{{ result.name }}</a>
44 </li>
45 {% endfor %}
46 </ul>
47
48=== modified file 'templates/ci/project_detail.html'
49--- templates/ci/project_detail.html 2013-07-31 22:07:43 +0000
50+++ templates/ci/project_detail.html 2013-09-19 21:57:04 +0000
51@@ -1,6 +1,6 @@
52 {% extends "layout.html" %}
53-{% load dashboard_extras staticfiles %}
54-{% load percentage %}
55+{% load url from future %}
56+{% load dashboard_extras staticfiles percentage %}
57 {% block extra_headers %}
58 <link type="text/css" href="//cdnjs.cloudflare.com/ajax/libs/nvd3/0.9/nv.d3.css" rel="stylesheet" />
59 <script type="text/javascript" src="//cdnjs.cloudflare.com/ajax/libs/d3/3.2.2/d3.min.js"></script>
60@@ -29,7 +29,7 @@
61 //]]>
62 </script>
63 <script type="text/javascript">
64- d3.json('{% url ci_api_project project.launchpad_project.name %}', function(data) {
65+ d3.json('{% url "ci_api_project" project.launchpad_project.name %}', function(data) {
66 nv.addGraph(function() {
67 var chart = nv.models.lineChart()
68 .width(1100).height(400);
69@@ -90,7 +90,7 @@
70 {% for job in job_list %}
71 <tr>
72 <td>
73- <a href='{% url ci_job job.name %}'>{{ job.name }}</a>
74+ <a href='{% url "ci_job" job.name %}'>{{ job.name }}</a>
75 </td>
76 <td>
77 <a href='{{ job.last_build.url }}'>{{ job.last_build.number }}</a>
78
79=== modified file 'templates/ci/project_list.html'
80--- templates/ci/project_list.html 2013-08-07 19:00:37 +0000
81+++ templates/ci/project_list.html 2013-09-19 21:57:04 +0000
82@@ -1,4 +1,5 @@
83 {% extends "ci/ci_layout.html" %}
84+{% load url from future %}
85 {% load dashboard_extras percentage staticfiles %}
86
87 {% block page_name %}Upstream merger results for all projects{% endblock %}
88@@ -32,11 +33,11 @@
89 </h3>
90 <ul class='left_nav'>
91 <li>
92- <a href='{% url ci_projects %}'>All</a>
93+ <a href='{% url "ci_projects" %}'>All</a>
94 </li>
95 {% for release in release_list %}
96 <li>
97- <a href='{% url ci_projects %}?show={{ release }} '>{{ release }}</a>
98+ <a href='{% url "ci_projects" %}?show={{ release }} '>{{ release }}</a>
99 </li>
100 {% endfor %}
101 </ul>
102@@ -72,7 +73,7 @@
103 {% for project in project_list %}
104 <tr>
105 <td>
106- <a href='{% url ci_project project.name %}'>{{ project.name }}</a>
107+ <a href='{% url "ci_project" project.name %}'>{{ project.name }}</a>
108 </td>
109 <td>
110 {{ project.ci_project.last_successful_build.timestamp }}
111
112=== modified file 'templates/ci/stack_list.html'
113--- templates/ci/stack_list.html 2013-07-22 17:41:38 +0000
114+++ templates/ci/stack_list.html 2013-09-19 21:57:04 +0000
115@@ -1,6 +1,6 @@
116 {% extends "ci/ci_layout.html" %}
117-{% load dashboard_extras %}
118-{% load ci_extras %}
119+{% load url from future %}
120+{% load dashboard_extras ci_extras %}
121
122 {% block page_name %}CI{% endblock %}
123
124@@ -30,11 +30,11 @@
125 </h3>
126 <ul class='left_nav'>
127 <li>
128- <a href='{% url stacks %}'>All</a>
129+ <a href='{% url "stacks" %}'>All</a>
130 </li>
131 {% for release in release_list %}
132 <li>
133- <a href='{% url stacks %}?show={{ release }} '>{{ release }}</a>
134+ <a href='{% url "stacks" %}?show={{ release }} '>{{ release }}</a>
135 </li>
136 {% endfor %}
137 </ul>
138@@ -53,7 +53,7 @@
139 {% for stack in stack_list %}
140 <tr>
141 <td>
142- <a href='{% url stacks %}{{ stack.name }}/'>{{ stack.name }}</a>
143+ <a href='{% url "stacks" %}{{ stack.name }}/'>{{ stack.name }}</a>
144 </td>
145 <td class='{{ stack.status|stack_status_color }}'>
146 {{ stack.status }}

Subscribers

People subscribed via source and target branches

to all changes: