Merge lp:~cjohnston/charms/trusty/neutron-gateway/doc-fixes into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Chris Johnston
Status: Merged
Merged at revision: 139
Proposed branch: lp:~cjohnston/charms/trusty/neutron-gateway/doc-fixes
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 139 lines (+17/-17)
2 files modified
README.md (+12/-12)
config.yaml (+5/-5)
To merge this branch: bzr merge lp:~cjohnston/charms/trusty/neutron-gateway/doc-fixes
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+271196@code.launchpad.net

Commit message

Documentation fixes in README and config

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10065 neutron-gateway-next for cjohnston mp271196
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10065/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9231 neutron-gateway-next for cjohnston mp271196
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9231/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6451 neutron-gateway-next for cjohnston mp271196
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12420594/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6451/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.md'
2--- README.md 2015-05-07 09:27:07 +0000
3+++ README.md 2015-09-15 20:27:52 +0000
4@@ -4,11 +4,11 @@
5 Neutron provides flexible software defined networking (SDN) for OpenStack.
6
7 This charm is designed to be used in conjunction with the rest of the OpenStack
8-related charms in the charm store) to virtualized the network that Nova Compute
9+related charms in the charm store to virtualize the network that Nova Compute
10 instances plug into.
11
12-Its designed as a replacement for nova-network; however it does not yet
13-support all of the features as nova-network (such as multihost) so may not
14+It's designed as a replacement for nova-network; however it does not yet
15+support all of the features of nova-network (such as multihost) so may not
16 be suitable for all.
17
18 Neutron supports a rich plugin/extension framework for propriety networking
19@@ -20,14 +20,14 @@
20 Usage
21 -----
22
23-In order to use Neutron with Openstack, you will need to deploy the
24+In order to use Neutron with OpenStack, you will need to deploy the
25 nova-compute and nova-cloud-controller charms with the network-manager
26 configuration set to 'Neutron':
27
28 nova-cloud-controller:
29 network-manager: Neutron
30
31-This decision must be made prior to deploying Openstack with Juju as
32+This decision must be made prior to deploying OpenStack with Juju as
33 Neutron is deployed baked into these charms from install onwards:
34
35 juju deploy nova-compute
36@@ -43,7 +43,7 @@
37
38 The gateway provides two key services; L3 network routing and DHCP services.
39
40-These are both required in a fully functional Neutron Openstack deployment.
41+These are both required in a fully functional Neutron OpenStack deployment.
42
43 See upstream [Neutron multi extnet](http://docs.openstack.org/trunk/config-reference/content/adv_cfg_l3_agent_multi_extnet.html)
44
45@@ -53,14 +53,14 @@
46 External Port Configuration
47 ===========================
48
49-If the port to be used for external traffic is consistent accross all physical
50+If the port to be used for external traffic is consistent across all physical
51 servers then is can be specified by simply setting ext-port to the nic id:
52
53 neutron-gateway:
54 ext-port: eth2
55
56 However, if it varies between hosts then the mac addresses of the external
57-nics for each host can be passed as a space seperated list:
58+nics for each host can be passed as a space separated list:
59
60 neutron-gateway:
61 ext-port: <MAC ext port host 1> <MAC ext port host 2> <MAC ext port host 3>
62@@ -71,7 +71,7 @@
63
64 If multiple floating pools are needed then an L3 agent (which corresponds to
65 a neutron-gateway for the sake of this charm) is needed for each one. Each
66-gateway needs to be deployed as a seperate service so that the external
67+gateway needs to be deployed as a separate service so that the external
68 network id can be set differently for each gateway e.g.
69
70 juju deploy neutron-gateway neutron-gateway-extnet1
71@@ -100,8 +100,8 @@
72
73 juju set neutron-gateway instance-mtu=1400
74
75-OpenStack upstream documentation recomments a MTU value of 1400:
76-[Openstack documentation](http://docs.openstack.org/admin-guide-cloud/content/openvswitch_plugin.html)
77+OpenStack upstream documentation recommends a MTU value of 1400:
78+[OpenStack documentation](http://docs.openstack.org/admin-guide-cloud/content/openvswitch_plugin.html)
79
80 Note that this option was added in Havana and will be ignored in older releases.
81
82@@ -125,7 +125,7 @@
83 Note that there are only two 'name' values the charm knows about: 'requirements'
84 and 'neutron'. These repositories must correspond to these 'name' values.
85 Additionally, the requirements repository must be specified first and the
86-neutron repository must be specified last. All other repostories are installed
87+neutron repository must be specified last. All other repositories are installed
88 in the order in which they are specified.
89
90 The following is a full list of current tip repos (may not be up-to-date):
91
92=== modified file 'config.yaml'
93--- config.yaml 2015-08-18 21:13:11 +0000
94+++ config.yaml 2015-09-15 20:27:52 +0000
95@@ -38,7 +38,7 @@
96 NOTE: updating this setting to a source that is known to provide
97 a later version of OpenStack will trigger a software upgrade.
98
99- NOTE: when openstack-origin-git is specified, openstack specific
100+ NOTE: when openstack-origin-git is specified, OpenStack specific
101 packages will be installed from source rather than from the
102 openstack-origin repository.
103 openstack-origin-git:
104@@ -126,7 +126,7 @@
105 Configure DHCP services to provide MTU configuration to instances
106 within the cloud. This is useful in deployments where its not
107 possible to increase MTU on switches and physical servers to
108- accomodate the packet overhead of using GRE tunnels.
109+ accommodate the packet overhead of using GRE tunnels.
110 enable-l3-agent:
111 type: boolean
112 default: True
113@@ -147,7 +147,7 @@
114 description: |
115 Used by the nrpe-external-master subordinate charm.
116 A string that will be prepended to instance name to set the host name
117- in nagios. So for instance the hostname would be something like:
118+ in Nagios. So for instance the hostname would be something like:
119 juju-myservice-0
120 If you're running multiple environments with the same services in them
121 this allows you to differentiate between them.
122@@ -155,7 +155,7 @@
123 default: ""
124 type: string
125 description: |
126- A comma-separated list of nagios servicegroups.
127+ A comma-separated list of Nagios servicegroups.
128 If left empty, the nagios_context will be used as the servicegroup
129 bridge-mappings:
130 type: string
131@@ -201,7 +201,7 @@
132 If True will enable Pacemaker to monitor the neutron-ha-monitor daemon
133 on every neutron-gateway unit, which detects neutron agents status and
134 reschedule resources hosting on failed agents, detects local errors and
135- release resources when network is unreachable or do neccessary recover
136+ release resources when network is unreachable or do necessary recover
137 tasks. This feature targets to < Juno which doesn't natively support HA
138 in Neutron itself.
139 ha-bindiface:

Subscribers

People subscribed via source and target branches