Merge lp:~cjcurran/indicator-sound/title-changing into lp:~indicator-applet-developers/indicator-sound/trunk_3
Proposed by
Conor Curran
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 124 | ||||
Proposed branch: | lp:~cjcurran/indicator-sound/title-changing | ||||
Merge into: | lp:~indicator-applet-developers/indicator-sound/trunk_3 | ||||
Diff against target: |
104 lines (+30/-10) 3 files modified
src/mpris2-controller.vala (+15/-5) src/sound-service-dbus.c (+3/-3) src/title-menu-item.vala (+12/-2) |
||||
To merge this branch: | bzr merge lp:~cjcurran/indicator-sound/title-changing | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2011-02-01.
Description of the change
Allows players to dynamically change the title on the player item.
This is a requirement for ubuntu one streaming client
To post a comment you must log in.
65 + public void alter_label (string new_title) set(MENUITEM_ NAME, new_title);
66 + {
67 + if (new_title != null) return;
68 + this.property_
69 + }
This method is a no-op unless new_title == NULL, in which case it sets the MENUITEM_NAME property to null... That doesn't look right?