Code review comment for lp:~cjcurran/indicator-sound/sigabrt

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

8 + if (priv->connection == NULL ||
9 + g_dbus_connection_is_closed (priv->connection) == TRUE){
10 + g_critical ("sound_service_dbus_update_sound_state - connection no good !!");
11 + return;
12 + }
13 +

If this occurs I think it's crucial for debugging to know which one of the two conditions happened?

Maybe like this instead:

+ if (priv->connection == NULL || g_dbus_connection_is_closed (priv->connection)) {
+ g_critical ("sound_service_dbus_update_sound_state - connection is %s !!",
+ connection == NULL? "NULL" : "closed");
+ return;
+ }

But no biggie. Approved.

review: Approve

« Back to merge proposal