8 + if (priv->connection == NULL || 9 + g_dbus_connection_is_closed (priv->connection) == TRUE){ 10 + g_critical ("sound_service_dbus_update_sound_state - connection no good !!"); 11 + return; 12 + } 13 +
If this occurs I think it's crucial for debugging to know which one of the two conditions happened?
Maybe like this instead:
+ if (priv->connection == NULL || g_dbus_connection_is_closed (priv->connection)) { + g_critical ("sound_service_dbus_update_sound_state - connection is %s !!", + connection == NULL? "NULL" : "closed"); + return; + }
But no biggie. Approved.
« Back to merge proposal
8 + if (priv->connection == NULL || connection_ is_closed (priv->connection) == TRUE){ service_ dbus_update_ sound_state - connection no good !!");
9 + g_dbus_
10 + g_critical ("sound_
11 + return;
12 + }
13 +
If this occurs I think it's crucial for debugging to know which one of the two conditions happened?
Maybe like this instead:
+ if (priv->connection == NULL || g_dbus_ connection_ is_closed (priv->connection)) { service_ dbus_update_ sound_state - connection is %s !!",
+ g_critical ("sound_
+ connection == NULL? "NULL" : "closed");
+ return;
+ }
But no biggie. Approved.